fix(warnings): drop redundant super::super glob imports - #8493
Merged
Conversation
The warnings job (RUSTFLAGS=-D warnings) fails on Linux with six 'unused import: super::super::*' errors in perry-codegen's node_core tables and three in perry-runtime's node_stream_constructors. Each of those files already carries 'use super::*;', and the parent module re-exports the grandparent surface, so the second glob is redundant. Pre-existing on main, not from any one PR, and INTERMITTENT: main at f5a8dcf passed warnings in run 32389924489 and failed the identical SHA in run 32396350265 — consistent with glob-import resolution shifting under feature unification, which also explains why macOS never flagged it. warnings is in both pr-gate and full-suite-gate, so this blocked every PR and the release. Verified: perry-codegen + perry-runtime compile on macOS without the globs (so they were redundant there too, not platform-load-bearing), and the exact CI command — RUSTFLAGS='-D warnings' cargo check --workspace --all-targets with the same nine UI excludes — is clean.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThe change removes nine redundant ChangesRedundant glob import cleanup
Estimated code review effort: 1 (Trivial) | ~3 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
added a commit
that referenced
this pull request
Aug 20, 2026
#8494) #8493 removed the nine 'unused import: super::super::*' sites rustc reported first, but warnings stayed RED on 415f4e2 — the very commit carrying that fix — because those errors masked the rest: rustc stops reporting once a crate fails, so each fix reveals the next batch. Fix the class in one pass instead of one CI cycle at a time. Found every file carrying BOTH 'use super::super::*;' and 'use super::*;' (24 across object/global_this, object/object_ops, object/native_call_method and node_stream_constructors), removed the redundant glob from all of them, and let the compiler arbitrate which were actually needed: perry-runtime compiles with zero errors, so none was load-bearing. Verified: the exact CI invocation — RUSTFLAGS='-D warnings' cargo check --workspace --all-targets with the nine UI excludes — is clean; cargo fmt clean; perry-runtime object:: unit tests 201 passed. No file in crates/ now carries both globs. Refs #8493 Co-authored-by: Ralph Küpper <ralph@skelpo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
warningsjob (RUSTFLAGS=-D warnings) fails on Linux with nineunused import: \super::super::*`errors — six inperry-codegen'snode_coretables, three inperry-runtime'snode_stream_constructors`.Pre-existing and not attributable to one PR, and notably intermittent: main at
f5a8dcf9cpassedwarningsin run 32389924489 and failed the identical SHA in run 32396350265. That flakiness, plus the fact that macOS never flags it, is consistent with glob-import resolution shifting under feature unification.warningsis in bothpr-gateandfull-suite-gate, so this was blocking every PR and the release.Why removal is the right fix, checked rather than assumed: each of these files already has
use super::*;, and the parent module re-exports the grandparent's surface, so the second glob adds nothing. I explicitly tested the risk that it was platform-load-bearing on macOS (where it is not reported unused):cargo check -p perry-codegen -p perry-runtimecompiles cleanly without it, so it was redundant there too.Verified: the exact CI invocation —
RUSTFLAGS='-D warnings' cargo check --workspace --all-targetswith the same nine UI excludes — is clean on this branch, andcargo fmt --checkpasses.Summary by CodeRabbit
Bug Fixes
Documentation