fix(warnings): sweep the remaining redundant super::super glob imports - #8494
Merged
Conversation
#8493 removed the nine 'unused import: super::super::*' sites rustc reported first, but warnings stayed RED on 415f4e2 — the very commit carrying that fix — because those errors masked the rest: rustc stops reporting once a crate fails, so each fix reveals the next batch. Fix the class in one pass instead of one CI cycle at a time. Found every file carrying BOTH 'use super::super::*;' and 'use super::*;' (24 across object/global_this, object/object_ops, object/native_call_method and node_stream_constructors), removed the redundant glob from all of them, and let the compiler arbitrate which were actually needed: perry-runtime compiles with zero errors, so none was load-bearing. Verified: the exact CI invocation — RUSTFLAGS='-D warnings' cargo check --workspace --all-targets with the nine UI excludes — is clean; cargo fmt clean; perry-runtime object:: unit tests 201 passed. No file in crates/ now carries both globs. Refs #8493
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (25)
📝 WalkthroughWalkthroughThe change removes 24 redundant ChangesGlob import cleanup
Estimated code review effort: 1 (Trivial) | ~3 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes what #8493 started.
warningsstayed red on415f4e22e— the very commit that carried #8493 — because rustc stops reporting once a crate fails, so the nine sites it named first were masking the rest. Fixing them one CI cycle at a time would take several more rounds.This handles the class in one pass: every file carrying both
use super::super::*;anduse super::*;— 24 of them, acrossobject/global_this,object/object_ops,object/native_call_methodandnode_stream_constructors.Verified empirically rather than by inspection. I removed all 24 at once and let the compiler arbitrate which were load-bearing:
perry-runtimecompiles with zero errors, so none was. (Worth checking, because these are not flagged unused on macOS — the same asymmetry that made #8493's originals hard to attribute.)Checks run:
RUSTFLAGS='-D warnings' cargo check --workspace --all-targetswith the same nine UI excludes — cleancargo fmt --checkcleanperry-runtimeobject::unit tests: 201 passedcrates/carries both globs any morewarningsis in bothpr-gateandfull-suite-gate, so this is release-gating.Summary by CodeRabbit
Chores
Tests