Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8494-redundant-glob-imports.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix(warnings): drop nine redundant `use super::super::*;` glob imports (six in `perry-codegen`'s `node_core` tables, three in `perry-runtime`'s `node_stream_constructors`). Each file already has `use super::*;`, and each parent module re-exports the grandparent's surface, so the second glob adds nothing — but rustc flags it as unused on Linux, and the `warnings` job runs `-D warnings`, so it failed there while passing on macOS. It was also intermittent on a single SHA, which points at glob-resolution shifting with feature unification. `warnings` gates both `pr-gate` and `full-suite-gate`, so this was blocking every PR and the release.
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::*;
use super::*;

pub(crate) const NODE_CORE_ASSERT_ROWS: &[NativeModSig] = &[
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::*;
use super::*;

pub(crate) const NODE_CORE_DGRAM_FS_OS_ROWS: &[NativeModSig] = &[
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::*;
use super::*;

pub(crate) const NODE_CORE_INSPECTOR_VM_ROWS: &[NativeModSig] = &[
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::*;
use super::*;

pub(crate) const NODE_CORE_MODULE_SEA_TLS_TEST_ROWS: &[NativeModSig] = &[
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::*;
use super::*;

pub(crate) const NODE_CORE_URL_PUNYCODE_CONSOLE_ROWS: &[NativeModSig] = &[
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::*;
use super::*;

pub(crate) const NODE_CORE_UTIL_BUFFER_ROWS: &[NativeModSig] = &[
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! node:stream — the `js_node_stream_*_new` / `*_subclass_init` constructors
//! and `Readable.from` factory (split out of node_stream_constructors.rs for
//! the 2000-line file-size gate, #1987).
use super::super::*;
use super::*;
use crate::closure::ClosureHeader;
use crate::object::{js_object_get_field_by_name_f64, js_object_set_field_by_name, ObjectHeader};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
//! `_isArrayBufferView` type predicates), default-highWaterMark accessors and
//! abort-signal wiring (split out of node_stream_constructors.rs for the
//! 2000-line file-size gate, #1987).
use super::super::*;
use super::*;
use crate::closure::{js_closure_alloc, js_closure_set_capture_ptr};
use crate::value::JSValue;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! node:stream — `Duplex.from`, `compose`, `finished`, `pipeline` and
//! `duplexPair` (split out of node_stream_constructors.rs for the 2000-line
//! file-size gate, #1987).
use super::super::*;
use super::*;
use crate::closure::{
js_closure_alloc, js_closure_get_capture_f64, js_closure_set_capture_f64, ClosureHeader,
Expand Down
Loading