Skip to content

Commit 415f4e2

Browse files
proggeramlugRalph Küpper
andauthored
fix(warnings): drop redundant super::super glob imports (#8493)
The warnings job (RUSTFLAGS=-D warnings) fails on Linux with six 'unused import: super::super::*' errors in perry-codegen's node_core tables and three in perry-runtime's node_stream_constructors. Each of those files already carries 'use super::*;', and the parent module re-exports the grandparent surface, so the second glob is redundant. Pre-existing on main, not from any one PR, and INTERMITTENT: main at f5a8dcf passed warnings in run 32389924489 and failed the identical SHA in run 32396350265 — consistent with glob-import resolution shifting under feature unification, which also explains why macOS never flagged it. warnings is in both pr-gate and full-suite-gate, so this blocked every PR and the release. Verified: perry-codegen + perry-runtime compile on macOS without the globs (so they were redundant there too, not platform-load-bearing), and the exact CI command — RUSTFLAGS='-D warnings' cargo check --workspace --all-targets with the same nine UI excludes — is clean. Co-authored-by: Ralph Küpper <ralph@skelpo.com>
1 parent ae7293f commit 415f4e2

10 files changed

Lines changed: 1 addition & 9 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
fix(warnings): drop nine redundant `use super::super::*;` glob imports (six in `perry-codegen`'s `node_core` tables, three in `perry-runtime`'s `node_stream_constructors`). Each file already has `use super::*;`, and each parent module re-exports the grandparent's surface, so the second glob adds nothing — but rustc flags it as unused on Linux, and the `warnings` job runs `-D warnings`, so it failed there while passing on macOS. It was also intermittent on a single SHA, which points at glob-resolution shifting with feature unification. `warnings` gates both `pr-gate` and `full-suite-gate`, so this was blocking every PR and the release.

crates/perry-codegen/src/lower_call/native_table/node_core/assert.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
pub(crate) const NODE_CORE_ASSERT_ROWS: &[NativeModSig] = &[

crates/perry-codegen/src/lower_call/native_table/node_core/dgram_fs_os.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
pub(crate) const NODE_CORE_DGRAM_FS_OS_ROWS: &[NativeModSig] = &[

crates/perry-codegen/src/lower_call/native_table/node_core/inspector_vm.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
pub(crate) const NODE_CORE_INSPECTOR_VM_ROWS: &[NativeModSig] = &[

crates/perry-codegen/src/lower_call/native_table/node_core/module_sea_tls_test.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
pub(crate) const NODE_CORE_MODULE_SEA_TLS_TEST_ROWS: &[NativeModSig] = &[

crates/perry-codegen/src/lower_call/native_table/node_core/url_punycode_console.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
pub(crate) const NODE_CORE_URL_PUNYCODE_CONSOLE_ROWS: &[NativeModSig] = &[

crates/perry-codegen/src/lower_call/native_table/node_core/util_buffer.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
pub(crate) const NODE_CORE_UTIL_BUFFER_ROWS: &[NativeModSig] = &[

crates/perry-runtime/src/node_stream_constructors/builders.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
//! node:stream — the `js_node_stream_*_new` / `*_subclass_init` constructors
22
//! and `Readable.from` factory (split out of node_stream_constructors.rs for
33
//! the 2000-line file-size gate, #1987).
4-
use super::super::*;
54
use super::*;
65
use crate::closure::ClosureHeader;
76
use crate::object::{js_object_get_field_by_name_f64, js_object_set_field_by_name, ObjectHeader};

crates/perry-runtime/src/node_stream_constructors/introspection.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
//! `_isArrayBufferView` type predicates), default-highWaterMark accessors and
44
//! abort-signal wiring (split out of node_stream_constructors.rs for the
55
//! 2000-line file-size gate, #1987).
6-
use super::super::*;
76
use super::*;
87
use crate::closure::{js_closure_alloc, js_closure_set_capture_ptr};
98
use crate::value::JSValue;

crates/perry-runtime/src/node_stream_constructors/pipeline.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
//! node:stream — `Duplex.from`, `compose`, `finished`, `pipeline` and
22
//! `duplexPair` (split out of node_stream_constructors.rs for the 2000-line
33
//! file-size gate, #1987).
4-
use super::super::*;
54
use super::*;
65
use crate::closure::{
76
js_closure_alloc, js_closure_get_capture_f64, js_closure_set_capture_f64, ClosureHeader,

0 commit comments

Comments
 (0)