Commit 415f4e2
fix(warnings): drop redundant super::super glob imports (#8493)
The warnings job (RUSTFLAGS=-D warnings) fails on Linux with six
'unused import: super::super::*' errors in perry-codegen's node_core
tables and three in perry-runtime's node_stream_constructors. Each of
those files already carries 'use super::*;', and the parent module
re-exports the grandparent surface, so the second glob is redundant.
Pre-existing on main, not from any one PR, and INTERMITTENT: main at
f5a8dcf passed warnings in run 32389924489 and failed the identical SHA
in run 32396350265 — consistent with glob-import resolution shifting under
feature unification, which also explains why macOS never flagged it.
warnings is in both pr-gate and full-suite-gate, so this blocked every PR
and the release.
Verified: perry-codegen + perry-runtime compile on macOS without the globs
(so they were redundant there too, not platform-load-bearing), and the
exact CI command — RUSTFLAGS='-D warnings' cargo check --workspace
--all-targets with the same nine UI excludes — is clean.
Co-authored-by: Ralph Küpper <ralph@skelpo.com>1 parent ae7293f commit 415f4e2
10 files changed
Lines changed: 1 addition & 9 deletions
File tree
- changelog.d
- crates
- perry-codegen/src/lower_call/native_table/node_core
- perry-runtime/src/node_stream_constructors
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
0 commit comments