Commit caba324
fix(warnings): sweep the remaining redundant super::super glob imports (#8494)
#8493 removed the nine 'unused import: super::super::*' sites rustc
reported first, but warnings stayed RED on 415f4e2 — the very commit
carrying that fix — because those errors masked the rest: rustc stops
reporting once a crate fails, so each fix reveals the next batch.
Fix the class in one pass instead of one CI cycle at a time. Found every
file carrying BOTH 'use super::super::*;' and 'use super::*;' (24 across
object/global_this, object/object_ops, object/native_call_method and
node_stream_constructors), removed the redundant glob from all of them,
and let the compiler arbitrate which were actually needed: perry-runtime
compiles with zero errors, so none was load-bearing.
Verified: the exact CI invocation — RUSTFLAGS='-D warnings' cargo check
--workspace --all-targets with the nine UI excludes — is clean; cargo fmt
clean; perry-runtime object:: unit tests 201 passed. No file in crates/
now carries both globs.
Refs #8493
Co-authored-by: Ralph Küpper <ralph@skelpo.com>1 parent 415f4e2 commit caba324
25 files changed
Lines changed: 1 addition & 24 deletions
File tree
- changelog.d
- crates/perry-runtime/src
- node_stream_constructors
- object
- global_this
- native_call_method
- object_ops
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
0 commit comments