Skip to content

Commit caba324

Browse files
proggeramlugRalph Küpper
andauthored
fix(warnings): sweep the remaining redundant super::super glob imports (#8494)
#8493 removed the nine 'unused import: super::super::*' sites rustc reported first, but warnings stayed RED on 415f4e2 — the very commit carrying that fix — because those errors masked the rest: rustc stops reporting once a crate fails, so each fix reveals the next batch. Fix the class in one pass instead of one CI cycle at a time. Found every file carrying BOTH 'use super::super::*;' and 'use super::*;' (24 across object/global_this, object/object_ops, object/native_call_method and node_stream_constructors), removed the redundant glob from all of them, and let the compiler arbitrate which were actually needed: perry-runtime compiles with zero errors, so none was load-bearing. Verified: the exact CI invocation — RUSTFLAGS='-D warnings' cargo check --workspace --all-targets with the nine UI excludes — is clean; cargo fmt clean; perry-runtime object:: unit tests 201 passed. No file in crates/ now carries both globs. Refs #8493 Co-authored-by: Ralph Küpper <ralph@skelpo.com>
1 parent 415f4e2 commit caba324

25 files changed

Lines changed: 1 addition & 24 deletions
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
fix(warnings): remove the remaining 24 redundant `use super::super::*;` glob imports across `perry-runtime` (`object/global_this`, `object/object_ops`, `object/native_call_method`, `node_stream_constructors`). #8493 fixed the nine rustc reported first; those errors were masking the rest, so `warnings` stayed red on the very commit that carried the earlier fix. Every file already has `use super::*;` and each parent re-exports the grandparent surface. Verified empirically rather than by inspection: all 24 were removed at once and `perry-runtime` still compiles with zero errors, so none was load-bearing.

crates/perry-runtime/src/node_stream_constructors/web_adapter.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
//! node:stream — WHATWG Web-stream interop (`Readable.toWeb`/`fromWeb`, the
22
//! adapter pumps, and the fallback stub) split out of
33
//! node_stream_constructors.rs for the 2000-line file-size gate, #1987.
4-
use super::super::*;
54
use super::*;
65
use crate::closure::{
76
js_closure_alloc, js_closure_get_capture_f64, js_closure_set_capture_f64, ClosureHeader,

crates/perry-runtime/src/object/global_this/array_error.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
pub(crate) fn global_this_rest_array_values(rest: f64) -> Vec<f64> {

crates/perry-runtime/src/object/global_this/ctor_thunks.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
pub(crate) fn normalize_eval_this_body(body: &str) -> Option<String> {

crates/perry-runtime/src/object/global_this/fetch_globals.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
crate::perry_thread_local! {

crates/perry-runtime/src/object/global_this/generator.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
/// Distinguishes plain vs async generator closures for the intrinsic-tower

crates/perry-runtime/src/object/global_this/install_static.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
#[no_mangle]

crates/perry-runtime/src/object/global_this/math_temporal.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32
// Math.* thunks live in the sibling `builtin_thunks` module (split out of
43
// `global_this`); pull them in directly so `install_math_namespace` resolves

crates/perry-runtime/src/object/global_this/populate.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32

43
/// Populate the freshly-allocated globalThis singleton with built-in

crates/perry-runtime/src/object/global_this/proto_methods.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use super::super::*;
21
use super::*;
32
// Array.prototype thunks live in the sibling `array_error` module (split out of
43
// `global_this`); pull them in directly so the prototype-install tables resolve

0 commit comments

Comments
 (0)