Skip to content

[10/11] refactor(deslop): share cycle detection traversal - #1485

Closed
aidenybai wants to merge 1 commit into
codex/internal-architecture-09-compatibility-guardrailsfrom
codex/internal-architecture-10-deslop-cycles
Closed

[10/11] refactor(deslop): share cycle detection traversal#1485
aidenybai wants to merge 1 commit into
codex/internal-architecture-09-compatibility-guardrailsfrom
codex/internal-architecture-10-deslop-cycles

Conversation

@aidenybai

@aidenybai aidenybai commented Jul 29, 2026

Copy link
Copy Markdown
Member

Part 10 of 11. Review this PR against codex/internal-architecture-09-compatibility-guardrails.

What changed

  • Replaces deslop's duplicate SCC traversal with the shared deterministic implementation introduced by the architecture gate.
  • Removes superseded cycle-walk code.

Why

Both dependency analysis and source-architecture validation need the same stable strongly connected component semantics.

Impact

Internal deduplication; deslop output behavior is preserved.

Validation

  • All 519 deslop tests
  • Differential type-analysis suite
  • Architecture cycle tests

Stack

Review only each PR's diff against its base branch. Merge in order.

  1. #1463 — Git service decomposition
  2. #1478 — Core execution pipeline
  3. #1479 — Workspace package graph
  4. #1480 — Package-aware rules
  5. #1487 — Private evaluator parity
  6. #1482 — API/LSP adapter facades
  7. #1483 — CLI workflow decomposition
  8. #1481 — CLI facade import migration
  9. #1484 — Architecture and compatibility gates
  10. #1485 — Shared deslop cycle traversal
  11. #1486 — Architecture docs and skill sync

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1485
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1485
npm i https://pkg.pr.new/react-doctor@1485

commit: bed7f55

@aidenybai

Copy link
Copy Markdown
Member Author

Closing this cycle-detection refactor slice as part of the regression-risk reduction. The original architecture stack has been replaced by four independent correctness/performance PRs that each target main. The full rewrite remains preserved on codex/internal-architecture-rewrite-full if we want to revisit it separately.

@aidenybai aidenybai closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant