Skip to content

[8/11] refactor(cli): migrate core imports to local facades - #1481

Closed
aidenybai wants to merge 1 commit into
codex/internal-architecture-07-cli-workflowsfrom
codex/internal-architecture-08-cli-facade-migration
Closed

[8/11] refactor(cli): migrate core imports to local facades#1481
aidenybai wants to merge 1 commit into
codex/internal-architecture-07-cli-workflowsfrom
codex/internal-architecture-08-cli-facade-migration

Conversation

@aidenybai

@aidenybai aidenybai commented Jul 29, 2026

Copy link
Copy Markdown
Member

Part 8 of 11. Review this PR against codex/internal-architecture-07-cli-workflows.

What changed

  • Mechanically migrates CLI and Ink imports from broad core imports to the local core facade modules.
  • Removes one now-redundant direct import path.

Why

This completes the adapter boundary introduced in Part 6 without mixing mechanical import churn into the workflow review.

Impact

No runtime behavior change. The diff is intentionally import-only and separately reviewable.

Validation

  • Full workspace typecheck at this exact commit
  • 11 core facade/source-boundary tests
  • Changed-scope React Doctor scan: 100/100

Stack

Review only each PR's diff against its base branch. Merge in order.

  1. #1463 — Git service decomposition
  2. #1478 — Core execution pipeline
  3. #1479 — Workspace package graph
  4. #1480 — Package-aware rules
  5. #1487 — Private evaluator parity
  6. #1482 — API/LSP adapter facades
  7. #1483 — CLI workflow decomposition
  8. #1481 — CLI facade import migration
  9. #1484 — Architecture and compatibility gates
  10. #1485 — Shared deslop cycle traversal
  11. #1486 — Architecture docs and skill sync

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1481
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1481
npm i https://pkg.pr.new/react-doctor@1481

commit: 2608609

@github-actions

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 2608609.

@aidenybai

Copy link
Copy Markdown
Member Author

Closing this CLI import migration slice as part of the regression-risk reduction. The original architecture stack has been replaced by four independent correctness/performance PRs that each target main. The full rewrite remains preserved on codex/internal-architecture-rewrite-full if we want to revisit it separately.

@aidenybai aidenybai closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant