Skip to content

[7/11] refactor(cli): decompose inspect workflow and rendering - #1483

Closed
aidenybai wants to merge 1 commit into
codex/internal-architecture-06-adapter-facadesfrom
codex/internal-architecture-07-cli-workflows
Closed

[7/11] refactor(cli): decompose inspect workflow and rendering#1483
aidenybai wants to merge 1 commit into
codex/internal-architecture-06-adapter-facadesfrom
codex/internal-architecture-07-cli-workflows

Conversation

@aidenybai

@aidenybai aidenybai commented Jul 29, 2026

Copy link
Copy Markdown
Member

Part 7 of 11. Review this PR against codex/internal-architecture-06-adapter-facades.

What changed

  • Splits inspect option resolution, scan planning, execution, cache handling, and rendering into focused modules.
  • Centralizes runtime layer construction and invocation-wide worker-slot ownership.
  • Extracts baseline comparison and action exit-code decisions into pure helpers.

Why

The CLI inspect path combined policy, orchestration, rendering, and cache lifecycle in one difficult-to-review flow.

Impact

Behavior-preserving internal refactor. Existing CLI commands, flags, output contracts, and telemetry semantics remain unchanged.

Validation

  • Full workspace typecheck at this exact commit
  • 39 focused workflow, rendering, baseline, and action-exit tests
  • Final full CLI suite: 2,435 tests

Stack

Review only each PR's diff against its base branch. Merge in order.

  1. #1463 — Git service decomposition
  2. #1478 — Core execution pipeline
  3. #1479 — Workspace package graph
  4. #1480 — Package-aware rules
  5. #1487 — Private evaluator parity
  6. #1482 — API/LSP adapter facades
  7. #1483 — CLI workflow decomposition
  8. #1481 — CLI facade import migration
  9. #1484 — Architecture and compatibility gates
  10. #1485 — Shared deslop cycle traversal
  11. #1486 — Architecture docs and skill sync

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1483
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1483
npm i https://pkg.pr.new/react-doctor@1483

commit: c228ef2

@github-actions

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit c228ef2.

@aidenybai

Copy link
Copy Markdown
Member Author

Closing this CLI workflow decomposition slice as part of the regression-risk reduction. The original architecture stack has been replaced by four independent correctness/performance PRs that each target main. The full rewrite remains preserved on codex/internal-architecture-rewrite-full if we want to revisit it separately.

@aidenybai aidenybai closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant