Skip to content

[6/11] refactor(adapters): add API and LSP core facades - #1482

Closed
aidenybai wants to merge 1 commit into
codex/internal-architecture-05-private-evaluatorfrom
codex/internal-architecture-06-adapter-facades
Closed

[6/11] refactor(adapters): add API and LSP core facades#1482
aidenybai wants to merge 1 commit into
codex/internal-architecture-05-private-evaluatorfrom
codex/internal-architecture-06-adapter-facades

Conversation

@aidenybai

@aidenybai aidenybai commented Jul 29, 2026

Copy link
Copy Markdown
Member

Part 6 of 11. Review this PR against codex/internal-architecture-05-private-evaluator.

What changed

  • Adds local core facades for the API, language server, and CLI package.
  • Routes API and LSP consumers through narrow adapter boundaries.
  • Adds boundary and project-graph ownership tests.

Why

Consumers should depend on intentional capability slices instead of the core package's broad internal surface.

Impact

Internal import architecture only; published facades remain unchanged.

Validation

  • Full workspace typecheck at this exact commit
  • API boundary tests
  • LSP boundary, invalidation, and ownership tests

Stack

Review only each PR's diff against its base branch. Merge in order.

  1. #1463 — Git service decomposition
  2. #1478 — Core execution pipeline
  3. #1479 — Workspace package graph
  4. #1480 — Package-aware rules
  5. #1487 — Private evaluator parity
  6. #1482 — API/LSP adapter facades
  7. #1483 — CLI workflow decomposition
  8. #1481 — CLI facade import migration
  9. #1484 — Architecture and compatibility gates
  10. #1485 — Shared deslop cycle traversal
  11. #1486 — Architecture docs and skill sync

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1482
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1482
npm i https://pkg.pr.new/react-doctor@1482

commit: 0f5f8e3

@github-actions

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 0f5f8e3.

@aidenybai

Copy link
Copy Markdown
Member Author

Closing this adapter facade refactor slice as part of the regression-risk reduction. The original architecture stack has been replaced by four independent correctness/performance PRs that each target main. The full rewrite remains preserved on codex/internal-architecture-rewrite-full if we want to revisit it separately.

@aidenybai aidenybai closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant