-
-
Notifications
You must be signed in to change notification settings - Fork 139
Localisation updates from https://translatewiki.net. #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
af5f2b5
to
1e1dff7
Compare
d098647
to
69e5e46
Compare
b358463
to
9785893
Compare
121a44c
to
8a3d92b
Compare
5fa0b5a
to
f101f2c
Compare
01a5801
to
8acada8
Compare
"Camachevaz" | ||
] | ||
}, | ||
"name": "Inglés", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the name of the language in itself. I guess this one should be "Español (formal)" or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange... this is not one of our steings right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. In en.json
is reads "name":"English"
and the translator simply translated it without paying attention to its special role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not fix this like this. A translation is a translation. The language name should come from the code and shoukd not be trnslated. We always display a language in its own language.
Where is this string used? We need to fox this in a dedicated issue... and it sounds like a regression.
We need to be careful to merge the translewiki PR at least once a month, otherewise manager of translatewiki come to me directly to ask what is going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not fix this like this. A translation is a translation. The language name should come from the code and shoukd not be trnslated. We always display a language in its own language.
And the name of the language comes from the translation file. The translators just need to pay attention to the description of that string from qqq.json that is displayed to them beside the translation text box:

Where is this string used?
The string is used in the UI language selector.
We need to fox this in a dedicated issue... and it sounds like a regression.
This is not a regression. It is just a translator not following the rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the previous comment, my links point to libkiwix
instead of kiwix-desktop
but the same argumentation applies to kiwix-desktop
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this string used?
The string is used in the UI language selector.
It looks like in kiwix-desktop
there is no UI to select the UI language (at least I couldn't find it). Then this string isn't used anywhere.
353584d
to
e5f6d4a
Compare
88830e0
to
52456a9
Compare
9cd083b
to
6022f67
Compare
6022f67
to
64361cb
Compare
64361cb
to
8484d83
Compare
Translation updates