Repository navigation
Port Playwright's check, wait-for-url, locator-list and selectors-text tests - #1064
Merged
Merged
Conversation
…t tests (Refs #1060) The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…nce of expected failures (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Member
Author
|
@coderabbitai review |
Contributor
Action not completed
|
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream added Playwright's own page tests to its testbed suite in one 130-file commit. This is the first slice of that port: the testbed learns to serve
/content(a page from base64 HTML, Playwright'spage.setContent) and Playwright's test assets, and four test files run on it. The next slices add the other files, listed in the plan on #1060.Upstream change ported. e2e-inc/e2e#1505, commit
bdf769b:apps/testbed/tests/{check,wait-for-url,locator-list,selectors-text}.e2e.ts,apps/testbed/tests/helpers.ts(content,PREFIX), andapps/testbed/app/playwright/routes.mjs(/content, the asset server) with the assetsempty.htmlandgrid.html,LICENSE, andNOTICE(Apache-2.0, kept next to the assets).Layout:
Check/PageCheckTests.cs(13),WaitForUrl/PageWaitForUrlTests.cs(7),LocatorList/LocatorListTests.cs(1),SelectorsText/SelectorsTextTests.cs(2), intests/E2E.NUnit.Tests, categoryplaywright(upstream's tag). 23 tests, all pass.Not ported, as upstream (its header lists them; the feature is missing in e2e too): check: label with
position, bothtrialruns,setChecked. wait-for-url:waitUntil(3 tests) andframe.waitForURL. selectors-text: 20 tests that needtext=/:textselectors,>>chains, or element handles.Known difference.
HasText_and_internal_text_should_match_full_node_text_in_strict_modekeeps all its assertions, but the firstGetByText("hello")match on<div id=div1><span id=span1>hello</span>world</div>has noid: #1062. It runs insideExpectedToFailAsyncand starts failing when that is fixed. The twouncheck ... by aria roletests are upstreamfail:tests too (uncheckrefusesrole=radio); they use the same helper..NET-only symbols.
Helpers.ExpectedToFailAsyncandHelpers.Equal(test-only): the port has nofailtest option (COMPATIBILITY.md), and NUnit records an assertion made in a test body even if the body catches it, soEqualthrows.PlaywrightTest(base class: playground base URL, cache off,playwrightcategory), in place of upstream'stest.describe(..., { requires: ['browser'], tags: ['playwright'] }).Helpers.PREFIXreads the testbed's own port, as upstream's fixed4271cannot work with a random port.PlaywrightRoutesis upstream'sroutes.mjs, so far/contentand the assets.Public API and docs: no change (test infrastructure only); COMPATIBILITY.md has one new line.
Refs #1060 (first slice; the other files are still to port)
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK