Repository navigation
Port Playwright's dialog and download tests (Refs #1060) - #1078
Conversation
…t tests (Refs #1060) The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…ith 400 (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…e (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…e call (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nput (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
Ports the dialog and download tests of the Playwright page suite (28
it): dialogs answered and auto-dismissed, and downloads from navigation, links, blobs, iframes and routing. Stacked on #1064 (base is that branch until it merges).Upstream change ported: e2e-inc/e2e#1505 (
bdf769b), filesapps/testbed/tests/dialog.e2e.ts(9) anddownload.e2e.ts(19: 12 indownload event, 7 indownload). The/download,/respondand/binaryroutes of upstreamroutes.mjsand the assetsdownload-blob.html,empty.pdf,chromium-linux.zipcome with it.Known difference kept as
ExpectedToFailAsync(upstream marks itfail):should be able to download a inline PDF file via response interception, becauseroute.fulfillbodies are strings and binary bytes do not survive.Not ported, as upstream (feature missing in e2e): the file headers list them:
dialogclosed,download.saveAs,delete,createReadStream,cancel,failure,acceptDownloads, context and browser control from the test..NET-only:
Helpers.Asset(upstream'sasset, a path under the test output).Refs #1060
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK