Skip to content

Port Playwright's dialog and download tests (Refs #1060) - #1078

Merged
kblok merged 13 commits into
mainfrom
issue-1060-dialog-download
Nov 5, 2026
Merged

kblok merged 13 commits into
mainfrom
issue-1060-dialog-download

Conversation

@kblok

@kblok kblok commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Ports the dialog and download tests of the Playwright page suite (28 it): dialogs answered and auto-dismissed, and downloads from navigation, links, blobs, iframes and routing. Stacked on #1064 (base is that branch until it merges).

Upstream change ported: e2e-inc/e2e#1505 (bdf769b), files apps/testbed/tests/dialog.e2e.ts (9) and download.e2e.ts (19: 12 in download event, 7 in download). The /download, /respond and /binary routes of upstream routes.mjs and the assets download-blob.html, empty.pdf, chromium-linux.zip come with it.

Known difference kept as ExpectedToFailAsync (upstream marks it fail): should be able to download a inline PDF file via response interception, because route.fulfill bodies are strings and binary bytes do not survive.

Not ported, as upstream (feature missing in e2e): the file headers list them: dialogclosed, download.saveAs, delete, createReadStream, cancel, failure, acceptDownloads, context and browser control from the test.

.NET-only: Helpers.Asset (upstream's asset, a path under the test output).

Refs #1060

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

kblok and others added 3 commits November 4, 2026 18:40
…t tests (Refs #1060)

The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between bb72ae5 and b01cea3.

Files ignored due to path filters: 2

  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/chromium-linux.zip is excluded by !**/*.zip
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/empty.pdf is excluded by !**/*.pdf
Files selected for processing: 5

  • tests/E2E.NUnit.Tests/Dialog/PageDialogTests.cs
  • tests/E2E.NUnit.Tests/Download/DownloadEventTests.cs
  • tests/E2E.NUnit.Tests/Download/DownloadTests.cs
  • tests/E2E.NUnit.Tests/Helpers/Helpers.cs
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/download-blob.html
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

kblok and others added 3 commits November 4, 2026 19:08
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Base automatically changed from issue-1060-playwright-page-tests to main November 4, 2026 22:24
kblok and others added 3 commits November 4, 2026 19:36
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…e call (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nput (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

kblok and others added 2 commits November 5, 2026 08:26
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok
kblok merged commit 8f1f072 into main Nov 5, 2026
4 checks passed
@kblok
kblok deleted the issue-1060-dialog-download branch November 5, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant