Repository navigation
Port Playwright's click, click-scroll and elementhandle-scroll-into-view tests - #1084
Conversation
…t tests (Refs #1060) The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…r tests (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…B chunks (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…iew tests (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Fixed: copied |
|
@coderabbitai review |
Action not completed
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…is fixed on main (Refs #1060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
Ports the click tests of Playwright's page tests (group B of #1060): the pointer, scrolling, and actionability cases that run against Playwright's input assets. The testbed also listens on
localhostnow, the second origin of the cross-origin click cases.Upstream change ported: e2e-inc/e2e#1505, commit
bdf769b.Ported (
playwrightcategory, one directory per upstream file, one class perdescribe):click.e2e.ts: 47it(Click/PageClickTests). Two loops (the six 1x1 divs, button/input enabled) are[TestCase]s. Not ported, as upstream: the 37 tests listed in the class summary (noforce,trial,clickCount,steps, element handles, Frame objects, events, abort signals, and some upstream left undone).click-scroll.e2e.ts: 6it(ClickScroll/PageClickScrollTests). Not ported, as upstream: oneforcetest, fourscroll: "none"tests, and one Chromium-skipped test.elementhandle-scroll-into-view.e2e.ts: 8it(ElementhandleScrollIntoView/ElementhandleScrollIntoViewTests). Not ported, as upstream: should throw for detached element.Known differences. Three tests fail because the port lacks what upstream has. Each keeps its upstream assertions inside
ExpectedToFailAsync, which passes while the body fails and fails once it passes:should click the button if window.Node is removed(#1079),should click zero-sized input by label(#1080),should work for visibility:hidden element(#1081)..NET-only:
Helpers.CROSS(upstream'sCROSS) and thelocalhostprefix of the testbed listener. COMPATIBILITY.md lists the ported files. No change tosrc/, so no SKILL.md or docs change.Refs #1060. Stacked on #1064: retarget to
mainafter it merges.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK