Skip to content

Port Playwright's frame page tests (Refs #1060) - #1070

Merged
kblok merged 11 commits into
mainfrom
issue-1060-frames
Nov 5, 2026
Merged

kblok merged 11 commits into
mainfrom
issue-1060-frames

Conversation

@kblok

@kblok kblok commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Ports the frame tests of the Playwright page suite (34 it). They check frameLocator queries, actions that wait for frames, and frame navigation, against Playwright's own frame assets.

Upstream change ported: e2e-inc/e2e#1505 (bdf769b), files apps/testbed/tests/locator-frame.e2e.ts (17), selectors-frame.e2e.ts (13), frame-goto.e2e.ts (1), frame-hierarchy.e2e.ts (3). Assets frames/* and shadow.html come with it.

Known differences kept as ExpectedToFailAsync (they fail today and start failing the day the port is fixed):

The three upstream fail tests about hidden iframes (#1067) pass in the port, so they run as normal tests.

Partial ports (Partial_ prefix): should send "framenavigated" when navigating on anchor URLs (no frame events, checks the URL only) and should report frame from-inside shadow DOM (no page.frames(), checks the iframe through locators).

Not ported, as upstream (feature missing in e2e): each file header lists them: element handles, locator.frameLocator, contentFrame, any-frame, Frame objects and frame events, $eval.

.NET-only: Helpers.CROSS (upstream's CROSS is a fixed port; the port uses localhost on the testbed's own port; the cross-origin test skips itself if localhost cannot bind), Helpers.After and Helpers.Record (upstream's delay(...).then and failure). The testbed answers Playwright routes on their own task and serves /never (upstream routes.mjs), because the listener loop was sequential and a held request would block every other one; held requests end at process exit or after 30 s.

Refs #1060

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

kblok and others added 3 commits November 4, 2026 18:40
…t tests (Refs #1060)

The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…e-hierarchy tests (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 85e973c and 8f79dda.

Files selected for processing: 12
  • tests/E2E.Agent.Tests/PlaywrightRoutes.cs
  • tests/E2E.Agent.Tests/Testbed.cs
  • tests/E2E.NUnit.Tests/FrameGoto/FrameGotoTests.cs
  • tests/E2E.NUnit.Tests/FrameHierarchy/FrameHierarchyTests.cs
  • tests/E2E.NUnit.Tests/Helpers/Helpers.cs
  • tests/E2E.NUnit.Tests/LocatorFrame/LocatorFrameTests.cs
  • tests/E2E.NUnit.Tests/SelectorsFrame/SelectorsFrameTests.cs
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/frames/child-redirect.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/frames/nested-frames.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/frames/one-frame.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/frames/redirect-my-parent.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/shadow.html
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

kblok and others added 2 commits November 4, 2026 19:02
…rarchy ports (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…ind and release held requests at exit (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Base automatically changed from issue-1060-playwright-page-tests to main November 4, 2026 22:24
kblok and others added 4 commits November 4, 2026 19:27
…route bugs with 500 (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok
kblok merged commit 88a9803 into main Nov 5, 2026
4 checks passed
@kblok
kblok deleted the issue-1060-frames branch November 5, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant