Skip to content

Conversation

@lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Nov 17, 2025

Description

Remove duplicate dependency.

How to Test

Validate select dropdown still works here or locally.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Nov 26, 2025 10:37pm
boundary-ui-desktop Ready Ready Preview Comment Nov 26, 2025 10:37pm


@use 'ember-basic-dropdown';
@use 'ember-power-select';

Copy link
Collaborator Author

@lisbet-alvarez lisbet-alvarez Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originally these imports got added when installing ember-basic-dropdown and ember-power-select.

  1. ember-basic-dropdown is a peer dep for hds components. Though it looks like this @use isn't necessary at all.
  2. ember-power-select was installed since some styles were needed so that an invisible element doesn't incorrectly render in the dropdown. However, @hashicc noticed that this dep was being installed twice now (since its also installed for hds components. In order to avoid installing it twice a workaround is to import the styles in app.js.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, did you need to add the <BasicDropdownWormhole /> that HDS mentions here?

Copy link
Collaborator Author

@lisbet-alvarez lisbet-alvarez Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup that was added here

@lisbet-alvarez lisbet-alvarez marked this pull request as ready for review November 17, 2025 23:14
@lisbet-alvarez lisbet-alvarez requested a review from a team as a code owner November 17, 2025 23:14
@lisbet-alvarez lisbet-alvarez mentioned this pull request Nov 17, 2025
10 tasks
cameronperera
cameronperera previously approved these changes Nov 17, 2025
Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the docs offer the import 'ember-power-select/styles'; option but I'm not seeing the power select styles in the vendor.css or admin.css. I do see the power select classes from hds. I'm not sure if there are caveats to this method? I'm not sure if I'm missing something or maybe these styles aren't needed?

@lisbet-alvarez
Copy link
Collaborator Author

lisbet-alvarez commented Nov 18, 2025

I know the docs offer the import 'ember-power-select/styles'; option but I'm not seeing the power select styles in the vendor.css or admin.css. I do see the power select classes from hds. I'm not sure if there are caveats to this method? I'm not sure if I'm missing something or maybe these styles aren't needed?

Looks like the styles are being injected directly into <style> when using the import option.
Screenshot 2025-11-18 at 11 11 52 AM
versus @use option
Screenshot 2025-11-18 at 11 14 03 AM

It doesn't seem like having the styles be injected directly into the DOM is ideal. Therefore, i think in the end we are still going to need the ember-power-select devDep. Unless I am misunderstanding

EDIT
Hds team approves of this approach & in future release they'll look into importing styles so consumers dont have to. hds team also updated docs 🙌.

@lisbet-alvarez lisbet-alvarez dismissed cameronperera’s stale review November 18, 2025 19:22

The merge-base changed after approval.

@lisbet-alvarez lisbet-alvarez force-pushed the llb/password-only-credential branch from 0afe551 to accf9fa Compare November 18, 2025 19:22
Base automatically changed from llb/password-only-credential to main November 18, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants