Llb/password only credential #3067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lisbet-alvarez
force-pushed
the
llb/password-only-credential
branch
from
d006336 to
7dd031f
Compare
lisbet-alvarez
force-pushed
the
llb/password-only-credential
branch
from
7dd031f to
6aea6df
Compare
lisbet-alvarez
force-pushed
the
llb/password-only-credential
branch
from
6aea6df to
0afe551
Compare
hashicc
reviewed
Nov 17, 2025
10 tasks
10 tasks
hashicc
approved these changes
Nov 18, 2025
Collaborator
hashicc
left a comment
hashicc
left a comment
There was a problem hiding this comment.
🚀 Nice test refactors, thanks for updating constants, lots of great work here
* feat: 🎸 add new password type to cred models + mirage * test: 💍 fix * refactor: 💡 update target mirage trait * chore: 🤖 add missing attr type
* refactor: 💡 credential type radio field to be select field * refactor: 💡 radio component to be select component * test: 💍 fix e2e test page * test: 💍 add correct selector to e2e test * test: 💍 fix
* feat: 🎸 add password credential form * test: 💍 add a11y ignores * test: 💍 fix e2e tests * test: 💍 add password cred type to targets brokering tests * chore: 🤖 remove comment
* refactor: 💡 update credential-library form for password type * style: 💄 fix display issue * test: 💍 add test cases
lisbet-alvarez
force-pushed
the
llb/password-only-credential
branch
from
0afe551 to
accf9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
passwordcredential type to credentials andpasswordcredential type to vault generic secrets credential library.Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.