Skip to content

refactor: 💡 remove ember-power-select duplicate dependency #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: 💡 remove ember-power-select duplicate dependency #3075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
546a4c3
refactor: 💡 remove ember-power-select duplicate dependency
lisbet-alvarez Nov 17, 2025
fdcc5aa
Merge branch 'main' into remove-dup-dep
lisbet-alvarez Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ui/admin/app/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import Application from '@ember/application';
import Resolver from 'ember-resolver';
import loadInitializers from 'ember-load-initializers';
import config from 'admin/config/environment';
import 'ember-power-select/styles';

export default class App extends Application {
modulePrefix = config.modulePrefix;
Expand Down
3 changes: 0 additions & 3 deletions ui/admin/app/styles/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
@use 'notify';
@use '@hashicorp/ember-asciinema-player';

@use 'ember-basic-dropdown';
@use 'ember-power-select';

Copy link
Collaborator Author

@lisbet-alvarez lisbet-alvarez Nov 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originally these imports got added when installing ember-basic-dropdown and ember-power-select.

  1. ember-basic-dropdown is a peer dep for hds components. Though it looks like this @use isn't necessary at all.
  2. ember-power-select was installed since some styles were needed so that an invisible element doesn't incorrectly render in the dropdown. However, @hashicc noticed that this dep was being installed twice now (since its also installed for hds components. In order to avoid installing it twice a workaround is to import the styles in app.js.

Copy link
Collaborator

@ZedLi ZedLi Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, did you need to add the <BasicDropdownWormhole /> that HDS mentions here?

Copy link
Collaborator Author

@lisbet-alvarez lisbet-alvarez Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup that was added here

.rose-layout-global {
.rose-layout-global-body {
justify-content: center;
Expand Down
1 change: 0 additions & 1 deletion ui/admin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"ember-load-initializers": "^2.1.2",
"ember-modifier": "^4.2.0",
"ember-page-title": "^8.2.3",
"ember-power-select": "^8.11.0",
"ember-qunit": "^8.1.0",
"ember-resolver": "^12.0.1",
"ember-source": "~5.12.0",
Expand Down
Loading