Fix Floating Combat Text panel

[huijiewei]

#106
#104

[gemini-code-assist]

Hello @huijiewei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issues #106 and #104, and aims to fix the Floating Combat Text panel. The changes involve updating the names of several options within the FloatingCombatTextConfigPanel.lua file. Specifically, it uses a fallback mechanism to display alternative text if the primary text is not available, ensuring a more robust and user-friendly experience.

Highlights

• Text Display Logic: The pull request modifies the display logic for option names in the Floating Combat Text configuration panel, using LOG_PERIODIC_EFFECTS_TEXT or LOG_PERIODIC_EFFECTS to provide a fallback.
• Pet Melee Damage Option: The pull request updates the name of the pet melee damage option, using SHOW_PET_MELEE_DAMAGE_TEXT or SHOW_PET_MELEE_DAMAGE to provide a fallback.
• Combat Healing Option: The pull request updates the name of the combat healing option, using SHOW_COMBAT_HEALING_TEXT or SHOW_COMBAT_HEALING to provide a fallback.

Changelog

• gui/FloatingCombatTextConfigPanel.lua
  • Modified the floatingCombatTextCombatLogPeriodicSpells option name to use LOG_PERIODIC_EFFECTS_TEXT or LOG_PERIODIC_EFFECTS.
  • Modified the floatingCombatTextPetMeleeDamage option name to use SHOW_PET_MELEE_DAMAGE_TEXT or SHOW_PET_MELEE_DAMAGE.
  • Modified the floatingCombatTextCombatHealing option name to use SHOW_COMBAT_HEALING_TEXT or SHOW_COMBAT_HEALING.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

Lua's design emphasizes simplicity and efficiency, making it a popular choice for scripting in games and embedded systems.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses the issue of missing text in the Floating Combat Text panel by providing fallback values when the primary text strings are not available. This is a good fix to ensure that the UI elements are always displayed correctly. The changes are straightforward and easy to understand.

Merge Readiness

The changes are simple and address a clear issue. I did not find any issues at the critical, high, or medium severity levels based on the instructions, and therefore believe this pull request is ready for merging. I am unable to directly approve this pull request, and recommend that other reviewers also take a look before merging.

[Stanzilla]

Thank you!