Skip to content

Fix Floating Combat Text panel #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2025
Merged

Fix Floating Combat Text panel #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ae4987
Fix Floating Combat Text panel
huijiewei Mar 29, 2025
b8aecee
Merge branch 'master' into master
Stanzilla Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gui/FloatingCombatTextConfigPanel.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function addon:CreateFloatingCombatTextOptions()
},
floatingCombatTextCombatLogPeriodicSpells = {
type = "toggle",
name = LOG_PERIODIC_EFFECTS,
name = LOG_PERIODIC_EFFECTS_TEXT or LOG_PERIODIC_EFFECTS,
desc = OPTION_TOOLTIP_LOG_PERIODIC_EFFECTS,
get = function()
return C_CVar.GetCVarBool("floatingCombatTextCombatLogPeriodicSpells")
Expand All @@ -102,7 +102,7 @@ function addon:CreateFloatingCombatTextOptions()
},
floatingCombatTextPetMeleeDamage = {
type = "toggle",
name = SHOW_PET_MELEE_DAMAGE,
name = SHOW_PET_MELEE_DAMAGE_TEXT or SHOW_PET_MELEE_DAMAGE,
desc = OPTION_TOOLTIP_SHOW_PET_MELEE_DAMAGE,
get = function()
return C_CVar.GetCVarBool("floatingCombatTextPetMeleeDamage")
Expand All @@ -129,7 +129,7 @@ function addon:CreateFloatingCombatTextOptions()
},
floatingCombatTextCombatHealing = {
type = "toggle",
name = SHOW_COMBAT_HEALING,
name = SHOW_COMBAT_HEALING_TEXT or SHOW_COMBAT_HEALING,
desc = OPTION_TOOLTIP_SHOW_COMBAT_HEALING,
get = function()
return C_CVar.GetCVarBool("floatingCombatTextCombatHealing")
Expand Down
Loading