Skip to content

[Guilds 02] Open a guild's own page, with its board and pinned commit - #190

Merged
simonhamp merged 1 commit into
NativePHP:mainfrom
shanesmithdev:guilds-02
Nov 21, 2026
Merged

simonhamp merged 1 commit into
NativePHP:mainfrom
shanesmithdev:guilds-02

Conversation

@shanesmithdev

@shanesmithdev shanesmithdev commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Status: Ready for review. Not blocked.

This follows on from #188 (Guilds 01), which is now merged, so it no longer blocks this PR. It adds a guild's own page, built only on guild API that is already merged and live on dev-null.sh.

What's in this PR?

  • A guild's page, as the web shows it:

    • Its icon, name, "#handle · Public guild · N members", what it's about, and how to post there ("Include #handle in any commit to post here.")
    • Its bulletin board, newest first, with the commit its moderator pinned shown first under "Pinned to board", and not repeated further down
    • The next page loads as you scroll, and pulling down refreshes
    • Share, in the top bar, shares the guild's page on the web
  • Opening it:

    • Tapping a guild in the directory opens its page, instead of searching for its hashtag
    • So does tapping the "posted in [guild]" message on a commit
    • Links to a guild on dev-null.sh in a commit open its page in the app, rather than the browser
  • When a guild can't be shown: a guild devnull no longer has says so, and if guilds are switched off it says so as the directory does.

What's still to come

The guild's members, and moderators pinning to the board, come in a follow-up PR once their dev-null.sh API is merged, with the rest of the guild features after that.

Testing

Pest tests cover:

  • the board data and its cache, including the pinned commit;
  • the guild's page: the board, the pinned commit shown once, loading more, refreshing, a missing guild and guilds switched off;
  • opening a guild from the directory, the "posted in" message and links in commits.

Locally, the full suite passes. Checked by hand on an iPhone 17 Pro simulator and an Android phone.

Screenshots

guild

Tapping a guild in the directory. Before is Guilds 01 (#188), which searches for the guild's hashtag. After is this PR, which opens the guild's page.

iOS light iOS dark Android light Android dark
Before
After

@shanesmithdev shanesmithdev changed the title [Guilds 02] Browse guilds, and show which guild a commit was posted in [Guilds 02] Open a guild's own page, with its board, members and pinned commit, in a new Guilds tab Nov 20, 2026
@shanesmithdev shanesmithdev changed the title [Guilds 02] Open a guild's own page, with its board, members and pinned commit, in a new Guilds tab [Guilds 02] Open a guild's own page, with its board and pinned commit Nov 21, 2026
@shanesmithdev
shanesmithdev marked this pull request as ready for review November 21, 2026 01:38
@shanesmithdev
shanesmithdev marked this pull request as draft November 21, 2026 01:43
@shanesmithdev
shanesmithdev marked this pull request as ready for review November 21, 2026 01:49
@simonhamp
simonhamp merged commit 1c19e4e into NativePHP:main Nov 21, 2026
3 checks passed
@simonhamp

Copy link
Copy Markdown
Member

😍

@shanesmithdev
shanesmithdev deleted the guilds-02 branch November 21, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants