Repository navigation
[Guilds 03] Post straight to a guild's board from its page - #197
Merged
Merged
Conversation
shanesmithdev
marked this pull request as ready for review
November 21, 2026 02:28
shanesmithdev
force-pushed
the
guilds-03
branch
from
November 21, 2026 10:42
9a42700 to
6b62eb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: Ready for review. Not blocked.
This follows on from #188 (Guilds 01) and #190 (Guilds 02), which are now merged, so they no longer block this PR. It lets you post straight to a guild's board from the guild's page, built only on guild API that is already merged and live on dev-null.sh.
What's in this PR?
A new commit button on a guild's page, beside Share. It isn't shown while the guild is paused, as the web shows no composer then.
The composer knows which guild it's posting to, as the web's guild composer does:
/featureand/bugaren't offered, as the web doesn't offer them thereThe post shows on the board straight away, staged until devnull has it, then the real commit takes its place. It never shows in the Log or your profile log, as it's posted to the guild only.
If devnull turns it down, it leaves the board and the draft opens again in that guild's composer with devnull's reason. It never reopens in the Log's composer, and a turned-down Log commit never reopens in a guild's composer.
Testing
Pest tests cover:
Note: #182 (Post as) adds an optional
$authorto the sameClientcommit methods that this PR gives an optional$guildHandle, so whichever lands second needs a small rebase.Locally, the full suite passes. Checked by hand on an iPhone 17 Pro simulator and an Android phone.
Screenshots
guild-compose
guild-compose-sheet