Skip to content

[Guilds 03] Post straight to a guild's board from its page - #197

Merged
simonhamp merged 1 commit into
NativePHP:mainfrom
shanesmithdev:guilds-03
Nov 21, 2026
Merged

simonhamp merged 1 commit into
NativePHP:mainfrom
shanesmithdev:guilds-03

Conversation

@shanesmithdev

@shanesmithdev shanesmithdev commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Status: Ready for review. Not blocked.

This follows on from #188 (Guilds 01) and #190 (Guilds 02), which are now merged, so they no longer block this PR. It lets you post straight to a guild's board from the guild's page, built only on guild API that is already merged and live on dev-null.sh.

What's in this PR?

  • A new commit button on a guild's page, beside Share. It isn't shown while the guild is paused, as the web shows no composer then.

  • The composer knows which guild it's posting to, as the web's guild composer does:

    • "What do you want to share with the guild?", with "Posted to this guild, not your profile log." under the field
    • Photos, polls, scheduling and mentions work as they do for any new commit
    • Its draft is kept separately for each guild, apart from your normal draft
    • /feature and /bug aren't offered, as the web doesn't offer them there
  • The post shows on the board straight away, staged until devnull has it, then the real commit takes its place. It never shows in the Log or your profile log, as it's posted to the guild only.

  • If devnull turns it down, it leaves the board and the draft opens again in that guild's composer with devnull's reason. It never reopens in the Log's composer, and a turned-down Log commit never reopens in a guild's composer.

Testing

Pest tests cover:

  • the new commit button, and that a paused guild has none;
  • the guild composer: its wording, its own draft, and no issue commands;
  • posting to the board with and without photos, and scheduling, with and without photos;
  • the staged commit on the board, its swap for the real one, and that it never shows in the Log;
  • turned-down posts reopening only on their own guild's page, including after the guild was paused meanwhile;
  • quoting from the board, which doesn't post the quote to the guild.

Note: #182 (Post as) adds an optional $author to the same Client commit methods that this PR gives an optional $guildHandle, so whichever lands second needs a small rebase.

Locally, the full suite passes. Checked by hand on an iPhone 17 Pro simulator and an Android phone.

Screenshots

guild-compose

Notice the new commit button beside Share in the guild page's top bar.

iOS light iOS dark Android light Android dark
Before
After

guild-compose-sheet

Completely new: the composer opened from a guild's page.

iOS light iOS dark Android light Android dark
After

@shanesmithdev
shanesmithdev marked this pull request as ready for review November 21, 2026 02:28
@simonhamp
simonhamp merged commit 607cf78 into NativePHP:main Nov 21, 2026
2 checks passed
@shanesmithdev
shanesmithdev deleted the guilds-03 branch November 21, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants