Skip to content

[Guilds 01] Browse guilds, and show which guild a commit was posted in - #188

Merged
simonhamp merged 1 commit into
NativePHP:mainfrom
shanesmithdev:implement-guilds
Nov 21, 2026
Merged

simonhamp merged 1 commit into
NativePHP:mainfrom
shanesmithdev:implement-guilds

Conversation

@shanesmithdev

@shanesmithdev shanesmithdev commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Status: Ready for review. Not blocked.

The first part of bringing /dev/null's guilds to the app, built only on guild API that is already merged and live on dev-null.sh.

Further dev-null.sh API changes are on the way. I'll submit additional PRs that build on top of this one once those extra APIs are available, to bring in the rest of the guild feature set so we have full parity with the web version.

What's in this PR?

  • Guilds directory:

    • A new Guilds tab, between Notifications and Remotes
    • Lists guilds biggest first, as the web does, with the same search ("Search names, #handles, and descriptions.")
    • The next page loads as you scroll with infinite scroll, which is even better than the web's Previous and Next buttons
    • Tapping a guild opens the commit search for its hashtag, because we can't implement guild pages yet (coming in Guilds 02)
  • The message "posted in [guild] · not shown in general logs" under commits posted straight to a guild's board, which is exactly how it also appears on the web.

  • If guild feature is switched off, handle that:

    • This was the case before general availability, and technically it is still possible that the web app can have guilds switched off again - even if that is unlikely.
    • Because of this, the app handles this gracefully and detects the scenario, hiding the Guilds tab when that happens. If it's switched back on again, the app will detect that and show the tab again from the next launch (iOS can't add or remove a tab while the app is running).

What's still to come

The rest of guilds needs API work that's open on dev-null.sh, not merged yet. I'll send follow-up PRs as each part lands:

Testing

Pest tests cover:

  • the guild data and the cache, including guild icons and their expired links;
  • the directory: search, a late answer for an old search term, loading more, empty states, the 404, and the kept first page;
  • the badge, and that Search leaves it out, as the web does;
  • hiding and bringing back the Guilds tab.

Locally, the full suite passes. Checked by hand on an iPhone 16e and iPhone 17 Pro simulator, and an Android phone.

Screenshots

guild-post

notice the "posted in [guild] - not shown in general logs" message in the after screenshots

iOS light iOS dark Android light Android dark
Before
After

guilds

Completely new interface, opened from the new Guilds tab

iOS light iOS dark Android light Android dark
After

guilds-empty

Guilds tab: Empty state

iOS light iOS dark Android light Android dark
After

guilds-scrolled

Guilds tab: I've scrolled down to show more of the uploaded icons

iOS light iOS dark Android light Android dark
After

guilds-search

Guilds tab: Searching for 'php'

iOS light iOS dark Android light Android dark
After

log

The only visible change is the new tab in the bottom bar

iOS light iOS dark Android light Android dark
Before
After

@shanesmithdev shanesmithdev changed the title [Guilds] Browse guilds, and show which guild a commit was posted in [Guilds 1/5] Browse guilds, and show which guild a commit was posted in Nov 20, 2026
@shanesmithdev shanesmithdev changed the title [Guilds 1/5] Browse guilds, and show which guild a commit was posted in [Guilds 01] Browse guilds, and show which guild a commit was posted in Nov 20, 2026
@shanesmithdev
shanesmithdev marked this pull request as draft November 20, 2026 10:30
@shanesmithdev

shanesmithdev commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Found a small oversight. Converted to draft temporarily while I fix it - I don't want this to be accidentally merged part way through my changes.

@shanesmithdev
shanesmithdev marked this pull request as ready for review November 20, 2026 10:37
@shanesmithdev

Copy link
Copy Markdown
Contributor Author

Upstream changes allow for using the uploaded icons for Guilds now, so I'll refactor this to use those rather than my temporary placeholder.

@shanesmithdev
shanesmithdev marked this pull request as draft November 20, 2026 13:19
@shanesmithdev

Copy link
Copy Markdown
Contributor Author

Because the next PR #190 was going to move the Guild icon to the bottom tab bar anyway, I've decided to just put it down there immediately in this PR instead. Please provide feedback on if this is where you want it to go.

@shanesmithdev

Copy link
Copy Markdown
Contributor Author

I've moved the guild icon down here, which feels like a very natural place for it. I'm concerned about making the tab bar too cluttered though, so please let me know what you think @simonhamp - should it stay here?

image

@shanesmithdev
shanesmithdev marked this pull request as ready for review November 21, 2026 00:02
Guilds come to the app on the API dev-null.sh has merged so far: that
means we have a guild directory, and if a commit was posted directly into
a guild we can show that. Tapping on a guild will open the regular search
for the hashtag, in the meantime.

Commits posted straight to a guild's board say "posted in [guild] ·
not shown in general logs", as it does on the web.

Guilds with an uploaded icon show a people glyph for now, since
devnull serves icons only to a signed-in browser and not over the API.

Other features are pending further upstream API changes.
@shanesmithdev

Copy link
Copy Markdown
Contributor Author

Squashed my reworking into a single commit. Ready for review again.

@simonhamp
simonhamp merged commit ba8a379 into NativePHP:main Nov 21, 2026
2 checks passed
@simonhamp

Copy link
Copy Markdown
Member

This is shaping up nicely!

@shanesmithdev
shanesmithdev deleted the implement-guilds branch November 21, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants