Repository navigation
[Guilds 01] Browse guilds, and show which guild a commit was posted in - #188
Conversation
|
Found a small oversight. Converted to draft temporarily while I fix it - I don't want this to be accidentally merged part way through my changes. |
90342ea to
5c157e2
Compare
|
Upstream changes allow for using the uploaded icons for Guilds now, so I'll refactor this to use those rather than my temporary placeholder. |
|
Because the next PR #190 was going to move the Guild icon to the bottom tab bar anyway, I've decided to just put it down there immediately in this PR instead. Please provide feedback on if this is where you want it to go. |
|
I've moved the guild icon down here, which feels like a very natural place for it. I'm concerned about making the tab bar too cluttered though, so please let me know what you think @simonhamp - should it stay here?
|
Guilds come to the app on the API dev-null.sh has merged so far: that means we have a guild directory, and if a commit was posted directly into a guild we can show that. Tapping on a guild will open the regular search for the hashtag, in the meantime. Commits posted straight to a guild's board say "posted in [guild] · not shown in general logs", as it does on the web. Guilds with an uploaded icon show a people glyph for now, since devnull serves icons only to a signed-in browser and not over the API. Other features are pending further upstream API changes.
867c331 to
00921bc
Compare
|
Squashed my reworking into a single commit. Ready for review again. |
|
This is shaping up nicely! |

Status: Ready for review. Not blocked.
The first part of bringing /dev/null's guilds to the app, built only on guild API that is already merged and live on dev-null.sh.
Further dev-null.sh API changes are on the way. I'll submit additional PRs that build on top of this one once those extra APIs are available, to bring in the rest of the guild feature set so we have full parity with the web version.
What's in this PR?
Guilds directory:
The message "posted in [guild] · not shown in general logs" under commits posted straight to a guild's board, which is exactly how it also appears on the web.
If guild feature is switched off, handle that:
What's still to come
The rest of guilds needs API work that's open on dev-null.sh, not merged yet. I'll send follow-up PRs as each part lands:
guild_mentionsto API responses.Testing
Pest tests cover:
Locally, the full suite passes. Checked by hand on an iPhone 16e and iPhone 17 Pro simulator, and an Android phone.
Screenshots
guild-post
guilds
guilds-empty
guilds-scrolled
guilds-search
log