ReadOnly: slightly restrict the dispatch on the setindex! method
#652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stricten up `Vararg{Any}` to `Vararg{Integer}`.
The stricter dispatch still satisfies the `AbstractArray` interface,
for both cases of `IndexStyle`.
The benefit is that `Integer` excludes some common types, such as
`CartesianIndex`. As a result, loading SparseArrays causes only $24$
invalidations in the sysimage after this change, as opposed to $26$
before this change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 84.02% 84.02%
=======================================
Files 12 12
Lines 9297 9297
=======================================
Hits 7812 7812
Misses 1485 1485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkarrasch
approved these changes
Sep 15, 2025
|
merge? |
KristofferC
pushed a commit
that referenced
this pull request
Sep 22, 2025
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stricten up
Vararg{Any}toVararg{Integer}.The stricter dispatch still satisfies the
AbstractArrayinterface, for both cases ofIndexStyle.The benefit is that$24$ invalidations in the sysimage after this change, as opposed to $26$ before this change.
Integerexcludes some common types, such asCartesianIndex. As a result, loading SparseArrays causes only