Backports for 1.12 #654
Merged
Backports for 1.12 #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed error message when trying to compute condition number of sparse matrix in 2-norm, suggesting 1 or Inf norm. Newbies like me or https://discourse.julialang.org/t/condition-number-of-sparse-matrix/77131/5 got diverted into trying densifying the array, which is very limited in many applications... --------- Co-authored-by: Viral B. Shah <[email protected]> Co-authored-by: Daniel Karrasch <[email protected]> (cherry picked from commit cff971d)
(cherry picked from commit 306605d)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #654 +/- ##
================================================
- Coverage 84.16% 84.15% -0.01%
================================================
Files 12 12
Lines 9178 9179 +1
================================================
Hits 7725 7725
- Misses 1453 1454 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
dot#641dot#642ReadOnlyfixes: prevent adding some methods ofsize,axes,eltype#649IndexStylemethod additions #650ReadOnly: slightly restrict the dispatch on thesetindex!method #652ReadOnly: do not add single-argument methods toeachindex, etc #653