ReadOnly: do not add single-argument methods to eachindex, etc
#653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add single-argument methods to: * `eachindex` * `firstindex` * `lastindex` The above have fallbacks that work as intended as long as the two two-argument methods of `eachindex` are defined. So add the two-argument methods of `eachindex` instead of adding single-argument methods of the three functions. On nightly Julia, together with PR #652, this PR decreases the amount of sysimage invalidations that happen when loading SparseArrays from $26$ to $17$. Without PR #652, this PR happens to increase the amount of invalidations, to $28$.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 84.02% 84.01% -0.01%
==========================================
Files 12 12
Lines 9297 9299 +2
==========================================
+ Hits 7812 7813 +1
- Misses 1485 1486 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkarrasch
previously approved these changes
Sep 15, 2025
Co-authored-by: Daniel Karrasch <[email protected]>
dkarrasch
approved these changes
Sep 16, 2025
|
merge? |
nsajko
deleted the
invalidations_fixes_readonly_eachindex-firstindex
branch
KristofferC
pushed a commit
that referenced
this pull request
Sep 22, 2025
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add single-argument methods to:
eachindexfirstindexlastindexThe above have fallbacks that work as intended as long as the two two-argument methods of
eachindexare defined.So add the two-argument methods of
eachindexinstead of adding single-argument methods of the three functions.On nightly Julia, together with PR #652, this PR decreases the amount of sysimage invalidations that happen when loading SparseArrays from$26$ to $17$ .
Without PR #652, this PR happens to increase the amount of invalidations, to$28$ .