fix: replace direct console.* calls with walletsLogger in wallets package#1592
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix: replace direct console.* calls with walletsLogger in wallets package#1592devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 902c517 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
Original prompt from Guillecan you determine the issue and propose a PR in case it's feasible to maintain the silent logs flag in every part of our sdks? |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
🔥 Smoke Test Results✅ Status: Passed Statistics
✅ All smoke tests passed!All critical flows are working correctly. This is a non-blocking smoke test. Full regression tests run separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the effort to make
consoleLogLevel="silent"work across all SDK packages. Three directconsole.*calls in the wallets package were bypassing theSdkLoggersystem, meaning they'd still appear even when a consumer setsconsoleLogLevel="silent"onCrossmintProvider.This replaces them with
walletsLogger:ncs-iframe-manager.ts: 2×console.info→walletsLogger.info(iframe init lifecycle)wallet.ts: 1×console.warn→walletsLogger.warn(deprecatedapproveTransactionmethod)Requested by: @xmint-guille
Link to Devin run
Test plan
walletsLoggeris initialized beforeNcsIframeManager.initialize()runs — if it isn't,SdkLoggerfalls back to rawconsole.*anyway, so logs would still leak in that edge casePackage updates
@crossmint/wallets-sdk: patch — changeset added via.changeset/wallets-use-sdk-logger.md