Skip to content

fix: replace direct console.* calls with walletsLogger in wallets package #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace direct console.* calls with walletsLogger in wallets package #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/wallets-use-sdk-logger.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@crossmint/wallets-sdk": patch
---

Replace direct console.* calls with walletsLogger to respect consoleLogLevel setting

Category: improvements
Product Area: wallets
5 changes: 3 additions & 2 deletions packages/wallets/src/signers/non-custodial/ncs-iframe-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { IFrameWindow, SignersWindowTransport, type HandshakeParent } from "@crossmint/client-sdk-window";
import { environmentUrlConfig, signerInboundEvents, signerOutboundEvents } from "@crossmint/client-signers";
import type { APIKeyEnvironmentPrefix } from "@crossmint/common-sdk-base";
import { walletsLogger } from "../../logger";

export type IframeConfig = {
environment: APIKeyEnvironmentPrefix;
Expand All @@ -16,7 +17,7 @@ export class NcsIframeManager {
return this.handshakeParent;
}

console.info("Initializing signers frame for the first time");
walletsLogger.info("Initializing signers frame for the first time");
const t0 = Date.now();
const iframeUrl = new URL(environmentUrlConfig[this.config.environment]);
iframeUrl.searchParams.set("targetOrigin", window.location.origin);
Expand All @@ -36,7 +37,7 @@ export class NcsIframeManager {
SignersWindowTransport
);
await this.handshakeParent.handshakeWithChild();
console.info(`Signers frame initialized in ${Date.now() - t0}ms`);
walletsLogger.info(`Signers frame initialized in ${Date.now() - t0}ms`);
return this.handshakeParent;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/src/wallets/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ export class Wallet<C extends Chain> {
*/
// TODO: Remove this method in the next major version
public async approveTransaction(params: ApproveParams) {
console.warn(
walletsLogger.warn(
"approveTransaction is deprecated. Use approve instead. This method will be removed in the next major version."
);
return await this.approve(params);
Expand Down