fix: replace direct console.* calls with windowLogger in window package by devin-ai-integration[bot] · Pull Request #1594 · Crossmint/crossmint-sdk

devin-ai-integration · 2026-02-20T17:37:14Z

Description

Replaces all 14 direct console.info() / console.error() calls in @crossmint/client-sdk-window with a new windowLogger (SdkLogger instance), so that these logs respect the consoleLogLevel setting (e.g. "silent").

Previously, the EventEmitter, HandshakeParent, and HandshakeChild classes logged directly to the console, bypassing the SDK logger system entirely.

This is part of a series of per-package PRs to route all SDK console output through SdkLogger. See related PRs: #1592 (wallets), #1593 (auth).

Files changed:

src/logger.ts — new file; creates windowLogger instance and initWindowLogger(apiKey) initializer
src/EventEmitter.ts — 10 console calls → windowLogger
src/handshake/Parent.ts — 2 console calls → windowLogger
src/handshake/Child.ts — 2 console calls → windowLogger
src/index.ts — exports windowLogger and initWindowLogger
package.json — adds @crossmint/common-sdk-base workspace dependency

⚠️ Items for reviewer attention

initWindowLogger is exported but never called within this package. A consuming package (e.g. react-base provider) must call initWindowLogger(apiKey) for the logger to be fully initialized. Until then, SdkLogger falls back to raw console.* — meaning the silent behavior won't take effect for window logs until the init call is wired up upstream.
New dependency: @crossmint/common-sdk-base is added to this previously minimal package (only had zod). Verify this is acceptable for bundle size.

Test plan

Lint passes (pnpm lint)
Manual verification: confirm no remaining direct console.* calls in packages/client/window/src/
No existing tests were broken (package has no test suite)

Package updates

@crossmint/client-sdk-window: patch (changeset added)

Link to Devin run: https://crossmint.devinenterprise.com/sessions/3befe224fd2b472594dafcd3fc100e7e
Requested by: @xmint-guille

changeset-bot · 2026-02-20T17:37:19Z

🦋 Changeset detected

Latest commit: fa67bad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages

Name	Type
@crossmint/client-sdk-window	Patch
@crossmint/client-sdk-base	Patch
@crossmint/client-sdk-react-base	Patch
@crossmint/client-sdk-rn-window	Patch
@crossmint/client-sdk-react-ui	Patch
@crossmint/wallets-sdk	Patch
@crossmint/client-sdk-nextjs-starter	Patch
@crossmint/client-sdk-auth	Patch
@crossmint/client-sdk-react-native-ui	Patch
@crossmint/client-sdk-verifiable-credentials	Patch
@crossmint/client-sdk-smart-wallet	Patch
@crossmint/common-sdk-auth	Patch
expo-demo	Patch
@crossmint/auth-ssr-nextjs-demo	Patch
@crossmint/wallets-quickstart-devkit	Patch
@crossmint/server-sdk	Patch
crossmint-auth-node	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

devin-ai-integration · 2026-02-20T17:37:21Z

Original prompt from Guille

we introduced the following change here to supress logs in our sdks:
https://github.com/Crossmint/crossmint-sdk/commit/27194e5751fd4bb3afb190550382760f978d7a20

i've tried this with the following code snippet, and I can still see logs once I'm logged in:
```ts
"use client";

import {
  CrossmintProvider,
  CrossmintAuthProvider,
  CrossmintWalletProvider,
  useAuth,
  useWallet,
} from "@crossmint/client-sdk-react-ui";

function WalletUser() {
  const { login, user } = useAuth();
  const { wallet, status } = useWallet();

  return (
    <div>
      {user == null ? (
        <button onClick={login}>Sign In</button>
      ) : (
        <p>
          Wallet: {wallet?.address} ({status})
        </p>
      )}
    </div>
  );
}

export default function Page() {
  return (
    <CrossmintProvider
      apiKey={process.env.NEXT_PUBLIC_CLIENT_API_KEY ?? ""}
      consoleLogLevel="silent"
    >
      <CrossmintAuthProvider>
        <CrossmintWalletProvider
          createOnLogin={{
            chain: "polygon-amoy",
            signer: { type: "email" },
          }}
        >
          <WalletUser />
        </CrossmintWalletProvider>
      </CrossmintAuthProvider>
    </CrossmintProvider>
  );
}

can you determine the issue and propose a PR in case it's feasible to maintain the silent logs flag in every part of our sdks?

</details>

devin-ai-integration · 2026-02-20T17:37:22Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI' or '@devin'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

greptile-apps

_{8 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-20T17:40:20Z

packages/client/window/src/logger.ts

+    const { environment, projectId } = validationResult;
+    windowLogger.init({
+        packageName: "@crossmint/client-sdk-window",
+        environment,
+        projectId,


packageVersion is missing from init params

The wallets package's initWalletsLogger passes both packageName and packageVersion to logger.init() (packages/wallets/src/logger/init.ts:30-31). This implementation should follow the same pattern for consistency and better log traceability.

Suggested change

const { environment, projectId } = validationResult;

windowLogger.init({

packageName: "@crossmint/client-sdk-window",

environment,

projectId,

const { environment, projectId } = validationResult;

windowLogger.init({

packageName: "@crossmint/client-sdk-window",

packageVersion: "1.0.9", // Consider importing from package.json via a constants file

environment,

projectId,

});

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/client/window/src/logger.ts Line: 16-20 Comment: `packageVersion` is missing from init params The wallets package's `initWalletsLogger` passes both `packageName` and `packageVersion` to logger.init() (packages/wallets/src/logger/init.ts:30-31). This implementation should follow the same pattern for consistency and better log traceability. ```suggestion const { environment, projectId } = validationResult; windowLogger.init({ packageName: "@crossmint/client-sdk-window", packageVersion: "1.0.9", // Consider importing from package.json via a constants file environment, projectId, }); ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-20T17:40:21Z

packages/client/window/src/logger.ts

+
+    const platform = detectPlatform();
+    if (platform === "browser") {
+        const sink = new BrowserDatadogSink(environment);
+        windowLogger.addSink(sink);
+    } else if (platform === "server") {
+        const sink = new ServerDatadogSink(environment);
+        windowLogger.addSink(sink);


use switch statement for consistency with wallets package pattern

The wallets package's initWalletsLogger uses a switch statement for platform handling (packages/wallets/src/logger/init.ts:38-61), which is more consistent and makes it easier to add future platforms like react-native.

Suggested change

const platform = detectPlatform();

if (platform === "browser") {

const sink = new BrowserDatadogSink(environment);

windowLogger.addSink(sink);

} else if (platform === "server") {

const sink = new ServerDatadogSink(environment);

windowLogger.addSink(sink);

const platform = detectPlatform();

switch (platform) {

case "browser": {

const sink = new BrowserDatadogSink(environment);

windowLogger.addSink(sink);

break;

}

case "server": {

const sink = new ServerDatadogSink(environment);

windowLogger.addSink(sink);

break;

}

default: {

// Unknown platform - only use console sink

break;

}

}

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/client/window/src/logger.ts Line: 22-29 Comment: use switch statement for consistency with wallets package pattern The wallets package's `initWalletsLogger` uses a switch statement for platform handling (packages/wallets/src/logger/init.ts:38-61), which is more consistent and makes it easier to add future platforms like react-native. ```suggestion const platform = detectPlatform(); switch (platform) { case "browser": { const sink = new BrowserDatadogSink(environment); windowLogger.addSink(sink); break; } case "server": { const sink = new ServerDatadogSink(environment); windowLogger.addSink(sink); break; } default: { // Unknown platform - only use console sink break; } } ``` <sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub> How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-20T17:40:22Z

packages/client/window/src/logger.ts

+export function initWindowLogger(apiKey: string): void {
+    const validationResult = validateAPIKey(apiKey);
+    if (!validationResult.isValid) {
+        return;


silently returning on invalid API key is inconsistent with the wallets package pattern

The wallets package's initWalletsLogger at packages/wallets/src/logger/init.ts:24-26 throws an error when the API key is invalid, while this implementation silently returns. This inconsistency could make debugging harder since users won't know why logging isn't working. Consider throwing an error with the validation message instead.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/client/window/src/logger.ts Line: 11-14 Comment: silently returning on invalid API key is inconsistent with the wallets package pattern The wallets package's `initWalletsLogger` at packages/wallets/src/logger/init.ts:24-26 throws an error when the API key is invalid, while this implementation silently returns. This inconsistency could make debugging harder since users won't know why logging isn't working. Consider throwing an error with the validation message instead. <sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub> How can I resolve this? If you propose a fix, please make it concise.

fix: replace direct console.* calls with windowLogger in window package

fa67bad

devin-ai-integration bot assigned xmint-guille Feb 20, 2026

devin-ai-integration bot requested a review from xmint-guille February 20, 2026 17:37

devin-ai-integration bot mentioned this pull request Feb 20, 2026

fix: replace direct console.* calls with SDK logger in react-base package #1595

Open

greptile-apps bot reviewed Feb 20, 2026

View reviewed changes

This was referenced Feb 20, 2026

fix: replace direct console.* calls with SDK logger in react-ui package #1596

Open

fix: replace direct console.* calls with rnWindowLogger in rn-window package #1597

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: replace direct console.* calls with windowLogger in window package#1594

fix: replace direct console.* calls with windowLogger in window package#1594
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1771608836-window-use-sdk-logger

devin-ai-integration bot commented Feb 20, 2026

Uh oh!

changeset-bot bot commented Feb 20, 2026

Uh oh!

devin-ai-integration bot commented Feb 20, 2026

Uh oh!

devin-ai-integration bot commented Feb 20, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 20, 2026

Uh oh!

greptile-apps bot Feb 20, 2026

Uh oh!

greptile-apps bot Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

devin-ai-integration bot commented Feb 20, 2026

Description

⚠️ Items for reviewer attention

Test plan

Package updates

Uh oh!

changeset-bot bot commented Feb 20, 2026

🦋 Changeset detected

Uh oh!

devin-ai-integration bot commented Feb 20, 2026

Uh oh!

devin-ai-integration bot commented Feb 20, 2026

🤖 Devin AI Engineer

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant