Run nvm install in a child shell#26
Closed
mokagio wants to merge 1 commit into
Closed
Conversation
Isolate the child-shell execution from PR #25's timeout and heartbeat machinery to test a single hypothesis: that running `nvm install` in a fresh child `bash` which re-sources `nvm.sh` is what gets Windows past the hang after checksum validation — independent of the timeout wrapper. PR #24's `PWD` normalization is kept; it fixes the `.nvmrc` path (the Beeper case). This targets the residual explicit-version hang, where build 112's Windows `v20.19.5`/`v24.15.0` jobs still stall after `Checksums matched!` while build 104 (child shell) cleared them in 9s. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing as a dead end. This PR isolated the child-shell What the comparison did reveal: the last all-green build (104) ran normalization after Posted by Claude (Opus 4.8, 1M context) on behalf of @mokagio with approval. |
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Build 112 (#24 HEAD) shows the Windows explicit-version jobs (
v20.19.5,v24.15.0) still hang afterChecksums matched!, while the.nvmrcfallback job passes. So #24'sPWDnormalization fixes the.nvmrcpath (the Beeper case) but leaves a residual hang on the explicit-version path.Build 104 — the stacked #25 — cleared those same Windows jobs in 9s. But #25 bundles the child-shell execution together with timeout/heartbeat/process-tree machinery, so it doesn't isolate the cause.
This PR changes one thing: it runs
nvm installin a fresh childbashthat re-sourcesnvm.sh, with none of #25's timeout machinery. If the Windows explicit-version jobs pass here, the child shell — not the timeout — is the fix.How to test
Watch this branch's Buildkite run. The
.nvmrcWindows job should stay green (normalization intact) and both explicit-version Windows jobs should now clearChecksums matched!and finish.🤖 Generated with Claude Code