Skip to content

Run nvm install in a child shell #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mokagio wants to merge 1 commit into from
Closed

Run nvm install in a child shell #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hooks/pre-command
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,13 @@ if [[ -n ${BUILDKITE_PLUGIN_NVM_VERSION:-} ]]; then
else
echo "Installing Node.js version specified in the .nvmrc file"
fi
nvm install "${install_args[@]}"
# Windows agents hang after checksum validation when `nvm install` runs in the parent hook shell.
# Running it in a fresh child shell that re-sources nvm gets past the hang.
bash -c '
set -e
source "$NVM_DIR/nvm.sh" --no-use
nvm install "$@"
' nvm-install "${install_args[@]}"

echo "~~~ :node: Activating Node.js"
if [[ -n ${BUILDKITE_PLUGIN_NVM_VERSION:-} ]]; then
Expand Down