Normalize PWD after sourcing nvm#27
Open
mokagio wants to merge 1 commit into
Open
Conversation
Move `nvm_plugin_normalize_windows_pwd_for_nvm` back to after `source nvm.sh`, reverting the reorder from e00aea8. This is a single-variable experiment. e00aea8 is the only change separating the last all-green build (104, normalize after source) from every build that hangs the explicit-version Windows jobs (111/112/113, normalize before source). If this build's Windows jobs pass, the before-source ordering is the cause of the hang. The exact hanging line can't be pinned from logs — the Windows hook's stdout is block-buffered and never flushes once it hangs — so this tests the ordering correlation empirically rather than a proven mechanism. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to the dead-end #26. Across builds, the only change separating the last all-green build (104 — normalization after
source nvm.sh) from every build that hangs the explicit-version Windows jobs (111/112/113 — normalization before) is commite00aea8, which moved normalization before the source.This PR reverts only that reorder — a single-variable test against build 112. If the explicit-version Windows jobs (
v20.19.5,v24.15.0) pass here, the before-source ordering is the cause.Tradeoff to check
e00aea8's before-source ordering is what reportedly fixed Beeper's.nvmrcWindows hang. This repo's.nvmrcWindows job passed in build 104 with the after-source ordering, but the Beeper downstream needs re-checking before this lands.How to test
Watch this branch's Buildkite run. Success = both explicit-version Windows jobs clear
Checksums matched!and finish, and the.nvmrcWindows job stays green.🤖 Generated with Claude Code