Skip to content

Conversation

@avisconti
Copy link
Contributor

@avisconti avisconti commented Oct 23, 2025

Align all sensor drivers that are using stmemsc (STdC) HAL i/f to new APIs of stmemsc v2.11.

Requires zephyrproject-rtos/hal_st#28

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_st zephyrproject-rtos/hal_st@9f81b44 zephyrproject-rtos/hal_st@6d03b42 (master) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 23, 2025
@avisconti avisconti added this to the v4.4.0 milestone Oct 23, 2025
@avisconti avisconti force-pushed the upgrade-stmems-v2.11 branch from a8bd131 to 4fa921a Compare October 28, 2025 15:42
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Oct 28, 2025
MaureenHelm
MaureenHelm previously approved these changes Oct 29, 2025
@avisconti avisconti added the DNM This PR should not be merged (Do Not Merge) label Oct 31, 2025
@avisconti avisconti force-pushed the upgrade-stmems-v2.11 branch from 4fa921a to 27c08ff Compare November 11, 2025 15:09
@github-actions github-actions bot added the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Nov 11, 2025
@avisconti avisconti removed the DNM This PR should not be merged (Do Not Merge) label Nov 11, 2025
@avisconti avisconti force-pushed the upgrade-stmems-v2.11 branch from 27c08ff to a553f0c Compare November 14, 2025 13:49
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Nov 14, 2025
@avisconti avisconti force-pushed the upgrade-stmems-v2.11 branch from a553f0c to 47f5f73 Compare November 14, 2025 14:54
Align all sensor drivers that are using stmemsc (STdC) HAL i/f
to new APIs of stmemsc v2.11.1

Requires zephyrproject-rtos/hal_st#27

Signed-off-by: Armando Visconti <[email protected]>
@avisconti avisconti force-pushed the upgrade-stmems-v2.11 branch from 47f5f73 to 661ec39 Compare November 14, 2025 16:16
@avisconti
Copy link
Contributor Author

rebased to have #99407 in.

@sonarqubecloud
Copy link

@kartben kartben merged commit a920a8b into zephyrproject-rtos:main Nov 18, 2025
28 checks passed
@avisconti avisconti deleted the upgrade-stmems-v2.11 branch November 18, 2025 10:49
@jhedberg
Copy link
Member

Looks like this broke CI: https://github.com/zephyrproject-rtos/zephyr/actions/runs/19462651912/job/55690305883

modules/hal_st/CMakeFiles/..__modules__hal__st.dir/sensor/stmemsc/lis2dux12_STdC/driver/lis2dux12_reg.c.obj -MF modules/hal_st/CMakeFiles/..__modules__hal__st.dir/sensor/stmemsc/lis2dux12_STdC/driver/lis2dux12_reg.c.obj.d -o modules/hal_st/CMakeFiles/..__modules__hal__st.dir/sensor/stmemsc/lis2dux12_STdC/driver/lis2dux12_reg.c.obj -c /__w/zephyr/modules/hal/st/sensor/stmemsc/lis2dux12_STdC/driver/lis2dux12_reg.c
/__w/zephyr/modules/hal/st/sensor/stmemsc/lis2dux12_STdC/driver/lis2dux12_reg.c:1219:7: error: variable 'ret' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
 1219 |   if (func_cfg_access.emb_func_reg_access == 0)
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/modules/hal/st/sensor/stmemsc/lis2dux12_STdC/driver/lis2dux12_reg.c:1248:10: note: uninitialized use occurs here
 1248 |   return ret;
      |          ^~~
/__w/zephyr/modules/hal/st/sensor/stmemsc/lis2dux12_STdC/driver/lis2dux12_reg.c:1219:3: note: remove the 'if' if its condition is always true
 1219 |   if (func_cfg_access.emb_func_reg_access == 0)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1220 |   {
/__w/zephyr/modules/hal/st/sensor/stmemsc/lis2dux12_STdC/driver/lis2dux12_reg.c:1208:14: note: initialize the variable 'ret' to silence this warning
 1208 |   int32_t ret;
      |              ^
      |               = 0

@avisconti
Copy link
Contributor Author

avisconti commented Nov 19, 2025

Looks like this broke CI: https://github.com/zephyrproject-rtos/zephyr/actions/runs/19462651912/job/55690305883

Yes, I have a fix for it. Did someone open an issue on zephyr?
@jhedberg

@jhedberg
Copy link
Member

Yes, I have a fix for it. Did someone open an issue on zephyr?

I'm not aware of it. Please provide the PR number here. It will be treated as a Hotfix.

@avisconti
Copy link
Contributor Author

avisconti commented Nov 19, 2025

Yes, I have a fix for it. Did someone open an issue on zephyr?

I'm not aware of it. Please provide the PR number here. It will be treated as a Hotfix.

zephyrproject-rtos/hal_st#29
#99669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants