Skip to content

Fix incorrect string formatting in barrier timeout exceptions #27149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2025
Merged

Fix incorrect string formatting in barrier timeout exceptions #27149

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1fd4b3
Fix incorrect string formatting in barrier timeout exceptions
hyongtao-code Oct 18, 2025
cfb6820
Post fix
hyongtao-code Oct 18, 2025
9673b39
Merge branch 'main' into fix-raise
hyongtao-code Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions vllm/distributed/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ def barrier(self, timeout: float = 30.0):
# Check for timeout
cur_time = time.time()
if cur_time - start_time > timeout:
raise RuntimeError("Barrier timed out after %f seconds", timeout)
raise RuntimeError(f"Barrier timed out after {timeout:.2f} seconds")

# Check for each process
for i in range(self.world_size):
Expand Down Expand Up @@ -323,7 +323,9 @@ def barrier(self, timeout: float = 30.0):
while len(processes_departed) < self.world_size:
# Check for timeout
if time.time() - start_time > timeout:
raise RuntimeError("Barrier departure timed out after %f s", timeout)
raise RuntimeError(
f"Barrier departure timed out after {timeout:.2f} seconds"
)

# Check for each process
for i in range(self.world_size):
Expand Down