Fix incorrect string formatting in barrier timeout exceptions #27149
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuntimeError was raised with an unformatted tuple due to printf-style arguments not being interpolated in Python exception constructors. Replaced with f-strings for proper message rendering. Signed-off-by: Yongtao Huang <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where RuntimeError exceptions in the barrier logic were raised with an unformatted tuple, making the error message unhelpful. The change to use f-strings not only resolves this issue but also improves the readability and consistency of the timeout messages by formatting the timeout value to two decimal places and using "seconds" uniformly. The fix is accurate and improves the code's robustness. I approve of these changes.
yewentao256
reviewed
Oct 18, 2025
hyongtao-code
force-pushed
the
fix-raise
branch
from
6c5a311 to
d724f67
Compare
Signed-off-by: Yongtao Huang <[email protected]>
hyongtao-code
force-pushed
the
fix-raise
branch
from
d724f67 to
cfb6820
Compare
yewentao256
approved these changes
Oct 18, 2025
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…roject#27149) Signed-off-by: Yongtao Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
RuntimeError was raised with an unformatted tuple due to printf-style arguments not being interpolated in Python exception constructors. Replaced with f-strings for proper message rendering.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.