Skip to content

Fix iTerm2 Settings window detection #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitorebatista merged 1 commit into from
Aug 27, 2026
Merged

Fix iTerm2 Settings window detection #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/AppBundle/model/AxUiElementWindowType.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ extension AxUiElementMock {
return false
}

if id == .iterm2 && fullscreenButton == nil {
if id == .iterm2 && fullscreenButton == nil && get(Ax.identifierAttr) != "mainPreferencesWindow" {
return false
}

Expand Down
105 changes: 105 additions & 0 deletions axDumps/iterm2_settings.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
{
"AXActivationPoint" : "<AXValue 0x6000012be5e0> {value = x:624.000000 y:295.000000 type = kAXValueCGPointType}",
"AXCancelButton" : null,
"AXCloseButton" : {
"AXEnabled" : 1,
"AXParent" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"AXRole" : "AXButton",
"AXSubrole" : "AXCloseButton",
"AXTitle" : null,
"AXTopLevelUIElement" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"AXWindow" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"Aero.AxFailed" : "get.AXTitle(noValue)",
"Aero.AxIgnored" : "AXFrame, AXSize, AXFocused, AXHelp, AXPosition, AXRoleDescription, AXEdited"
},
"AXDefaultButton" : null,
"AXDocument" : null,
"AXFocused" : 1,
"AXFrame" : "<AXValue 0x6000009b7100> {value = x:554.000000 y:281.000000 w:785.000000 h:435.000000 type = kAXValueCGRectType}",
"AXFullScreen" : 0,
"AXFullScreenButton" : null,
"AXGrowArea" : null,
"AXIdentifier" : "mainPreferencesWindow",
"AXMain" : 0,
"AXMinimizeButton" : {
"AXEnabled" : 1,
"AXParent" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"AXRole" : "AXButton",
"AXSubrole" : "AXMinimizeButton",
"AXTitle" : null,
"AXTopLevelUIElement" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"AXWindow" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"Aero.AxFailed" : "get.AXTitle(noValue)",
"Aero.AxIgnored" : "AXFrame, AXSize, AXFocused, AXHelp, AXPosition, AXRoleDescription"
},
"AXMinimized" : 0,
"AXModal" : 0,
"AXParent" : "<AXUIElement Application 0x6000012be5e0> {pid=82812}",
"AXPosition" : "<AXValue 0x600001270930> {value = x:554.000000 y:281.000000 type = kAXValueCGPointType}",
"AXProxy" : null,
"AXRole" : "AXWindow",
"AXSections" : [
"{\n SectionDescription = Content;\n SectionObject = \"<AXUIElement 0x600001231e60> {pid=82812}\";\n SectionUniqueID = AXContent;\n}",
"{\n SectionDescription = Toolbar;\n SectionObject = \"<AXUIElement 0x600001230b40> {pid=82812}\";\n SectionUniqueID = AXToolbar;\n}",
"{\n SectionDescription = Search;\n SectionObject = \"<AXUIElement 0x6000012302a0> {pid=82812}\";\n SectionUniqueID = AXSearch;\n}"
],
"AXSize" : "<AXValue 0x6000012a55c0> {value = w:785.000000 h:435.000000 type = kAXValueCGSizeType}",
"AXSubrole" : "AXDialog",
"AXTitle" : "Settings",
"AXTitleUIElement" : "AXUIElement(AxWindowId=375751, title=nil, role=\"AXStaticText\", subrole=nil)",
"AXToolbarButton" : null,
"AXZoomButton" : {
"AXEnabled" : 0,
"AXParent" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"AXRole" : "AXButton",
"AXSubrole" : "AXZoomButton",
"AXTitle" : null,
"AXTopLevelUIElement" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"AXWindow" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"Aero.AxFailed" : "get.AXTitle(noValue)",
"Aero.AxIgnored" : "AXFrame, AXSize, AXFocused, AXChildren, AXHelp, AXPosition, AXRoleDescription"
},
"Aero.AXApp" : {
"AXExtrasMenuBar" : null,
"AXFocusedUIElement" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"AXFocusedWindow" : "AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"AXFrame" : null,
"AXFrontmost" : 1,
"AXFunctionRowTopLevelElements" : [

],
"AXMainWindow" : "AXUIElement(AxWindowId=375694, title=\"terminal\", role=\"AXWindow\", subrole=\"AXStandardWindow\")",
"AXMenuBar" : "<AXUIElement 0x6000012acf30> {pid=82812}",
"AXPosition" : null,
"AXRole" : "AXApplication",
"AXSize" : null,
"AXTitle" : "iTerm2",
"AXWindows" : [
"AXUIElement(AxWindowId=375751, title=\"Settings\", role=\"AXWindow\", subrole=\"AXDialog\")",
"AXUIElement(AxWindowId=375694, title=\"terminal\", role=\"AXWindow\", subrole=\"AXStandardWindow\")"
],
"Aero.AxFailed" : "isWritable.AXFunctionRowTopLevelElements(failure), get.AXFrame(attributeUnsupported), isWritable.AXFrame(failure), get.AXExtrasMenuBar(noValue), isWritable.AXExtrasMenuBar(failure), get.AXSize(attributeUnsupported), isWritable.AXSize(attributeUnsupported), get.AXPosition(attributeUnsupported), isWritable.AXPosition(attributeUnsupported)",
"Aero.AxIgnored" : "AXChildren, AXChildrenInNavigationOrder, AXEnhancedUserInterface, AXPreferredLanguage, AXRoleDescription, AXHidden",
"Aero.AxWritable" : "AXFrontmost"
},
"Aero.App.appBundleId" : "com.googlecode.iterm2",
"Aero.App.nsApp.activationPolicy" : "regular",
"Aero.App.nsApp.appBundlePath" : "file:///Applications/iTerm.app/",
"Aero.App.nsApp.execPath" : "file:///Applications/iTerm.app/Contents/MacOS/iTerm2",
"Aero.App.pid" : 82812,
"Aero.App.version" : "3.6.11",
"Aero.App.versionShort" : "3.6.11",
"Aero.AxFailed" : "isWritable.AXFrame(failure), get.AXGrowArea(failure), get.AXDocument(noValue), isWritable.AXActivationPoint(failure), get.AXFullScreenButton(noValue), get.AXProxy(noValue), get.AXDefaultButton(noValue), get.AXCancelButton(noValue), get.AXToolbarButton(noValue)",
"Aero.AxIgnored" : "AXChildrenInNavigationOrder, AXChildren, AXRoleDescription",
"Aero.AxUiElementWindowType" : "dialog",
"Aero.AxUiElementWindowType_isDialogHeuristic" : true,
"Aero.AxWritable" : "AXPosition, AXSections, AXMinimized",
"Aero.axWindowId" : 375751,
"Aero.macOS.version" : "Version 15.7.4 (Build 24G517)",
"Aero.on-window-detected" : [

],
"Aero.treeNodeParent" : "Optional(AppBundle.MacosPopupWindowsContainer)",
"Aero.windowLevel" : "normalWindow",
"Aero.workspace" : null
}