Fix iTerm2 Settings window detection - #55
Merged
Merged
Conversation
iTerm2's Settings window has no fullscreen button, so the iTerm2-specific heuristic classified it as not-a-window and AeroSpace ignored it. Exempt the window whose AXIdentifier is `mainPreferencesWindow` from that check so the Settings window is detected as a dialog again. Ports nikitabobko#2244 Covered by the data-driven `AxWindowKindTest`: the new `axDumps/iterm2_settings.json5` fixture carries `"Aero.AxUiElementWindowType": "dialog"` inline and fails without the source change (verified). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBcwRe3CktWZGGcHJHP4ds
vitorebatista
added a commit
that referenced
this pull request
Aug 27, 2026
…te sync state Sync state moves to upstream main @ c548c7f / 59 open PRs, reviewed 2026-08-27. Adds the newly ported upstream PRs (2244, 2232, 2211, 2228, 2225) to the already-backported list, and records this cycle's skips: focus-follows-mouse PRs (nikitabobko#2238/nikitabobko#2245, feature absent in the fork), nikitabobko#2220 (duplicate of the already-ported nikitabobko#2024), nikitabobko#2213 (deletes lastNativeFocusedWindowId, which fork PR #59 depends on), nikitabobko#2206 (competing implementation of nikitabobko#2225), and six deferred feature PRs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBcwRe3CktWZGGcHJHP4ds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iTerm2's Settings window has no fullscreen button, so the iTerm2-specific heuristic in
AxUiElementWindowTypeclassified it as not-a-window and AeroSpace ignored it entirely. Exempt the window whoseAXIdentifierismainPreferencesWindowfrom that check.Ports nikitabobko#2244 (author: @Miyou), applied unchanged — no fork adaptation needed.
Tests: the fork's data-driven
AxWindowKindTestpicks up the newaxDumps/iterm2_settings.json5fixture, which carries"Aero.AxUiElementWindowType": "dialog"inline. Verified it fails without the source change and passes with it../build-debug.sh -Xswiftc -warnings-as-errors✅ ·./swift-test.sh✅Docs: none needed (no command/flag/config change).