fix: honour PR_SPLIT_* env vars for strategy and priority options - #52
Conversation
|
Warning Review limit reachedNext included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis change makes the documented Confidence Score: 5/5Safe to merge: the changed CLI path correctly applies the documented environment settings while preserving explicit command-line overrides. The command was exercised with all four environment values, enum and float conversion was confirmed at the planner boundary, explicit option precedence was checked, and focused CLI tests passed. Files Needing Attention: No files need further attention.
What T-Rex did
Reviews (1): Last reviewed commit: "fix: honour PR_SPLIT_* env vars for stra..." | Re-trigger Greptile |
README documents PR_SPLIT_PRIORITY, PR_SPLIT_CHUNK_STRATEGY and PR_SPLIT_PARTITION_STRATEGY, but the split command's options had no envvar binding, so their explicit defaults always overrode the environment. Bind them (plus the undocumented --cp-sat-timeout) and document the flag and its variable.
6dc1b98 to
ad8e59e
Compare
Summary
The README's Configuration table documents
PR_SPLIT_PRIORITY,PR_SPLIT_CHUNK_STRATEGYandPR_SPLIT_PARTITION_STRATEGY, but thesplitoptions had noenvvar=binding. Typer passed the explicit default intoSettings(...), which overrides pydantic-settings' env lookup, so the variables were silently ignored (verified:PR_SPLIT_PARTITION_STRATEGY=graphstill producedllm).envvaron--priority,--chunk-strategy,--partition-strategy, and--cp-sat-timeout(PR_SPLIT_CP_SAT_TIMEOUT)--cp-sat-timeout/PR_SPLIT_CP_SAT_TIMEOUT, which were missing from both README tablesTest plan
test_split_uses_strategy_envvarscovering all four variablesuv run ruff check/ruff format --checkcleanuv run pytest -q— 445 passed