fix: honor PR_SPLIT_PRIORITY, CHUNK_STRATEGY, PARTITION_STRATEGY and CP_SAT_TIMEOUT - #107
Closed
vitali87 wants to merge 1 commit into
Closed
fix: honor PR_SPLIT_PRIORITY, CHUNK_STRATEGY, PARTITION_STRATEGY and CP_SAT_TIMEOUT#107vitali87 wants to merge 1 commit into
vitali87 wants to merge 1 commit into
Conversation
…CP_SAT_TIMEOUT in split
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Closing as a duplicate of #52, which already contains this fix (my bug hunt ran against main and re-found it). Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README documents
PR_SPLIT_PRIORITY,PR_SPLIT_CHUNK_STRATEGYandPR_SPLIT_PARTITION_STRATEGY, butsplitignored them: those typer options (and--cp-sat-timeout) had noenvvar=, and their default values are passed explicitly toSettings(...), where init kwargs beat pydantic-settings' own env lookup.PR_SPLIT_PARTITION_STRATEGY=graph pr-split split …still demanded anANTHROPIC_API_KEY.The four options now declare
envvar="PR_SPLIT_…"(matching--min-loc/--max-loc),--helpshows them, an invalid value gives a clean typer error, and the README gains the missingPR_SPLIT_CP_SAT_TIMEOUTrow.Test plan
test_split_uses_strategy_priority_and_timeout_envvarssets all four env vars and checks theSettingspassed toplan_splitand the saved plan (fails on main)