Fix Docker node_modules and search_meta shadowing#558
Fix Docker node_modules and search_meta shadowing#558ericsandu wants to merge 3 commits intounikraft:mainfrom
Conversation
Generate search-meta directly at runtime in the mounted volume. Signed-off-by: Eric Sandu <eric_andrei.sandu@stud.acs.upb.ro>
04f3da2 to
774691a
Compare
|
I've updated the Dockerfile to include I've also added In regards to the linter errors I am not exactly knowledgeable on what specific version I should mention for the installed packages and if it even if a good idea to force versions directly. Advice would be greatly appreciated. |
a10d7f1 to
857ef09
Compare
Specifies node_modules location on the container to prevent shadowing with the local one. Signed-off-by: Eric Sandu <eric_andrei.sandu@stud.acs.upb.ro>
Adds necessary packages for Alpine and bypasses postinstall script during dependency installation. Signed-off-by: Eric Sandu <eric_andrei.sandu@stud.acs.upb.ro>
857ef09 to
8a5c8df
Compare
|
I have changed the Docker instructions in the Now this module will be shared between multiple docker instances of the documentation that might be running, and allow easy removal of it instead of having dangling anonymous volumes after the removal of the containers. |
cc7a9ad to
8a5c8df
Compare
This commit fixes #554 which is caused by the container not having access to installed
node_modulesdirectory, there being the possibly of it getting overwritten / shadowed by a currently existing one. The instructions inREADME.mdhave been accordingly to fix this problem by forcing the use of the containers node_modules directory.During testing I also discovered the possibility of the search-meta configuration getting overwritten, so the Dockerfile has been updated to generate it at runtime, preventing this issue.