Update deployment instructions with the correct commands #557
Open
ericsandu wants to merge 3 commits intounikraft:mainfrom
Open
Update deployment instructions with the correct commands #557ericsandu wants to merge 3 commits intounikraft:mainfrom
ericsandu wants to merge 3 commits intounikraft:mainfrom
Conversation
razvand
approved these changes
May 3, 2026
Contributor
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
See linter issue.
Also keep the use of the bind mount option for development builds (with -v: -v $(pwd):/docs -w /docs). They are required to render updates to the local directory without having to re-build the container.
ericsandu
force-pushed
the
ericsandu/fix-readme-inconsistencies
branch
from
fd650d2 to
ded1961
Compare
Refer to NPM as "npm" Signed-off-by: Eric Sandu <eric_andrei.sandu@stud.acs.upb.ro>
ericsandu
force-pushed
the
ericsandu/fix-readme-inconsistencies
branch
from
ded1961 to
83f7e12
Compare
Contributor
Author
|
The fixes for #554 have been moved to a separate pull request, as they are also related to the Dockerfile, which felt out of scope for this current pull request. The instructions in the contribution documentation are the same as those in the mentioned pull request. I have also made new commits fixing the linter errors I have found in both |
Signed-off-by: Eric Sandu <eric_andrei.sandu@stud.acs.upb.ro>
Signed-off-by: Eric Sandu <eric_andrei.sandu@stud.acs.upb.ro>
ericsandu
force-pushed
the
ericsandu/fix-readme-inconsistencies
branch
from
83f7e12 to
4a0ff14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unnecessary command line arguments that specify the location of the container, fixing #554 . With the Dockerfile being placed in the root of the repository they are not a necessity, and were the cause of the aforementioned issue.
The contribution documentation at
content/docs/contributing/docs.mdxhas also been updated to reflect the current top-level README, resolving #555 .The instructions for building locally without docker have also been updated to use the npm commands from the README.