Skip to content

fix(oUF): guard secret IsAuraFilteredOutByInstanceID returns in aura filter flags #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjodheim wants to merge 1 commit into from
+13 −4
Closed

fix(oUF): guard secret IsAuraFilteredOutByInstanceID returns in aura filter flags #1853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ElvUI_Libraries/Game/Shared/oUF/auraskip.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,27 @@ local function AllowAura(frame, aura)
return true
end

local function NotFilteredOut(unit, auraInstanceID, filter)
-- C_UnitAuras.IsAuraFilteredOutByInstanceID returns a SECRET boolean for secret auras in Midnight.
-- `not <secret>` would propagate secretness into the auraIsX flags and taint UF:VerifyFilter's
-- and/or chain (-> reduced budget -> "script ran too long"). Coerce to a plain boolean; a secret
-- aura defaults to false (not matched by this special filter) which is a safe, no-freeze default.
local filtered = IsAuraFilteredOutByInstanceID(unit, auraInstanceID, filter)
return oUF:NotSecretValue(filtered) and not filtered
end

local function InstanceFiltered(unit, aura, helpful, harmful)
local isHelpful = not IsAuraFilteredOutByInstanceID(unit, aura.auraInstanceID, helpful)
local isHarmful = not IsAuraFilteredOutByInstanceID(unit, aura.auraInstanceID, harmful)
local isHelpful = NotFilteredOut(unit, aura.auraInstanceID, helpful)
local isHarmful = NotFilteredOut(unit, aura.auraInstanceID, harmful)

return isHelpful or isHarmful
end

-- These flags are per-aura and do NOT depend on the filter, so compute them
-- once instead of recomputing identical values inside the 3x filter loop.
local function ComputeAuraFlags(unit, aura)
aura.auraIsHarmful = not IsAuraFilteredOutByInstanceID(unit, aura.auraInstanceID, 'HARMFUL')
aura.auraIsHelpful = not IsAuraFilteredOutByInstanceID(unit, aura.auraInstanceID, 'HELPFUL')
aura.auraIsHarmful = NotFilteredOut(unit, aura.auraInstanceID, 'HARMFUL')
aura.auraIsHelpful = NotFilteredOut(unit, aura.auraInstanceID, 'HELPFUL')

aura.auraIsImportant = InstanceFiltered(unit, aura, 'HELPFUL|IMPORTANT', 'HARMFUL|IMPORTANT')
aura.auraIsCancelable = InstanceFiltered(unit, aura, 'HELPFUL|CANCELABLE', 'HARMFUL|CANCELABLE')
Expand Down