fix(oUF): guard secret IsAuraFilteredOutByInstanceID returns in aura filter flags#1853
Open
mjodheim wants to merge 1 commit into
Open
fix(oUF): guard secret IsAuraFilteredOutByInstanceID returns in aura filter flags#1853mjodheim wants to merge 1 commit into
mjodheim wants to merge 1 commit into
Conversation
…filter flags C_UnitAuras.IsAuraFilteredOutByInstanceID returns a secret boolean for secret auras in Midnight (12.0). InstanceFiltered/ComputeAuraFlags did `not <return>` with no secret guard, so the auraIsX flags became secret and tainted UF:VerifyFilter's and/or chain, collapsing the execution budget -> "script ran too long" freezes during the per-aura filter loop (observed at UnitFrames/Elements/Auras.lua:760). Route the three call sites through a NotFilteredOut helper that coerces the result to a plain boolean via oUF:NotSecretValue; a secret aura defaults to false (not matched by the special filter). Strict no-op when the return is not secret. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Midnight (12.0),
C_UnitAuras.IsAuraFilteredOutByInstanceIDreturns a secret boolean for secret auras.InstanceFilteredandComputeAuraFlagsdidnot <return>with no secret guard, so theauraIsXflags became secret and taintedUF:VerifyFilter's and/or chain — collapsing the execution budget into "script ran too long" freezes during the per-aura filter loop (observed atUnitFrames/Elements/Auras.lua:760, stack throughoUF/elements/auras.lua->UF:AuraFilter->UF:VerifyFilter).These were the only unguarded
IsAuraFilteredOutByInstanceIDreturns in the file — every other API read here already usesoUF:NotSecretValue.Routes the three call sites through a
NotFilteredOuthelper that coerces the result to a plain boolean viaoUF:NotSecretValue; a secret aura defaults tofalse(not matched by the special filter), which is a safe no-freeze default. Theandshort-circuits sonotnever touches a secret value. Strict no-op when the return is not secret.Sits cleanly on top of the merged #1851 (
ComputeAuraFlags). Verified in-game: theAuras.lua:760watchdog error and the associated freezes are gone.