Remove "bookmarklet has been updated" alert#208
Open
bradp wants to merge 1 commit intotsitu:masterfrom
Open
Conversation
AardWolf
reviewed
Oct 6, 2022
Collaborator
AardWolf
left a comment
AardWolf
left a comment
There was a problem hiding this comment.
Removes all checking of stored key - no more popups. But we've recently dug through and found that if a key is stored it should be updated or auto-loader things won't work. This should probably also check that localstorage has something saved.
logicalup
changed the title
Collaborator
|
what does this pr need to move forward? |
Contributor
|
As you said in the original PR, this does work as intended. I just went to the CRE page and got an Instead of removing, it should just be less annoying even though it doesn't happen very often. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopen #197, as I accidentally deleted the forked repo