Remove "bookmarklet has been updated" alert#197
Closed
bradp wants to merge 1 commit intotsitu:masterfrom
mouseplace:remove-alert
Closed
Remove "bookmarklet has been updated" alert#197bradp wants to merge 1 commit intotsitu:masterfrom mouseplace:remove-alert
bradp wants to merge 1 commit intotsitu:masterfrom
mouseplace:remove-alert
Conversation
Collaborator
|
i think i said the same thing, but it's working as intended? it checks local storage, and if it's out of date, it will show the popup. If it's not out of date, it's not supposed to show the popup. i agree on the annoying side, but maybe a better solution would be to make it not an alert() but a modal? |
AardWolf
approved these changes
Oct 3, 2022
Collaborator
AardWolf
left a comment
AardWolf
left a comment
There was a problem hiding this comment.
This just removes the alert entirely, right? Seems like we could add a check to see if localStorage has anything for that storageKey then make the existing code an else if.
But I'm also ok with just removing the alerts.
Contributor
Author
|
:notlikeduck: Oops I deleted the wrong repo. |
bradp
added a commit
to bradp/MH-Tools
that referenced
this pull request
Oct 3, 2022
Contributor
Author
|
Please see #208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, every single user gets an
alert()fired in their face on the very first visit to any page. The annoyance of that + the fact that the alert does not get triggered when it has been updated means it should just be removed.