Vulkan: remove stale tess/grid compile-time feature gates#204
Draft
cursor[bot] wants to merge 1 commit into
Draft
Vulkan: remove stale tess/grid compile-time feature gates#204cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Remove USE_VBO_GRID and USE_TESS_NEEDS_* preprocessor branches from the Vulkan renderer. These macros were either unconditionally enabled (grid in VBO whenever USE_VBO) or never enabled (tess normal/ST2 commented out in tr_local.h), so the active code path matches the previous build. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of compile-time feature gates in the Vulkan renderer that were fully rolled out or never enabled, reducing dead branches and
tessstruct fields that could not be used in this configuration.Flags / gates removed
USE_VBO_GRIDtr_local.h,USE_VBOis always defined for Vulkan, andUSE_VBO_GRIDwas always defined in that case. The#elsepaths (non-grid / alternateVBO_Flushonly) were never compiled.USE_TESS_NEEDS_NORMALtr_local.h, the macro was commented out (not defined). The live build always took the “notess.needsNormalguard” path; the guarded branch was dead.USE_TESS_NEEDS_ST2tess.needsST2and conditional ST1 copying were dead.needsNormal/needsST2members were removed fromshaderCommands_tin the Vulkan header because they are unused after simplification.Note: The OpenGL renderer is unchanged; it still uses its own
tr_local.hand optionalUSE_TESS_NEEDS_NORMALwhere applicable.Behavioral parity
./scripts/compile_engine.sh vulkan(success).ctestinbuild-vk-Release: 26/26 tests passed (smoke, renderer checks, unit tests, script validation).Files touched
tr_local.h,vk_vbo.c,tr_surface.c,tr_shade.c,tr_main.c,tr_animation.c(Vulkan only).