Fixes #39667 - Remove some deprecated code - #11193
Draft
lzap wants to merge 3 commits into
Draft
Conversation
The top-level format_errors helper in db/seeds.rb was deprecated in 3.4 in favor of SeedHelper.format_errors and has no remaining callers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The instance method user_or_usergroup was deprecated in 3.12 in favor of the OwnerClassifier.classify_owner class method. With it gone the instance constructor is no longer used, so the class is now purely a set of class methods. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
css_tags_for was deprecated in 3.12; it is a no-op with no core callers. The only plugin referencing it (foreman_rh_cloud) defines its own copy, so core's can be dropped. webpacked_plugins_css_for is retained because foreman_leapp, foreman_openscap and foreman_puppet still call it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
lzap
force-pushed
the
deprecation-cleanup-39667
branch
from
August 20, 2026 15:51
b890944 to
b96a3fa
Compare
This was referenced Aug 20, 2026
Merged
Member
Author
|
I dropped one deprecation that was more complex, now it's three in total. Two of them are not referenced from any plugin we ship in Satellite, one is a trivial seed helper deprecation which is referenced from many plugins. Filed RM Issues and PRs into every one of them. Let's do not merge this until we have closed them. |
lzap
marked this pull request as draft
August 20, 2026 16:14
stejskalleos
self-requested a review
August 24, 2026 06:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is definitely not everything, only taking a look on the easy ones. Briefly tested locally, let's see what CI says.
https://community.theforeman.org/t/remove-foreman-deprecations-for-5-0-in-develop-core-plugins/47377
Edit: I was able to grep some instances of deprecated methods in some plugins, taking a deeper look.