Fixes #39673 - Use SeedHelper.format_errors in seeds - #1061
Merged
Conversation
lzap
force-pushed
the
deprecate-format-errors-39667
branch
from
September 7, 2026 08:43
3769575 to
b893526
Compare
lzap
changed the title
Member
|
The test failures are unrelated and will be fixed by #1067 |
ofedoren
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #39673
The top-level
format_errorsseed helper in Foreman core is deprecated (since 3.4) and is being removed as part of Foreman #39667 (theforeman/foreman#11193). This switches the plugin seed scripts to callSeedHelper.format_errorsdirectly.SeedHelper.format_errorshas been available since the helper was deprecated, so this change is backward compatible with all supported Foreman versions and can be merged independently of the core removal.🤖 Generated with Claude Code