Use sudo with the askpass option instead of pkexec #1902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swiftly installation currently uses
pkexecto handle authentication when running the post install script. However, this will not work in dev containers or in a remote ssh environment.This PR switches to using
sudowith askpass to have VS Code ask for the administrator password instead. The askpass functionality is done in a similar way to how the VS Code git extension does it: by having a shell script run a Node application that connects to the Swift extension via an HTTP server.Tasks
[ ] Documentation has been updated[ ] Added an entry to CHANGELOG.md if applicable