show output when post-install script fails

Author: matthewbastien

src/toolchain/swiftly.ts

@@ -856,14 +856,18 @@ export class Swiftly {
                 `Swift ${version} post-install script executed successfully. Additional system packages have been installed.`
             );
         } catch (error) {
-            const errorMsg = `Failed to execute post-install script: ${error}`;
-            logger?.error(errorMsg);
-            outputChannel.appendLine("");
-            outputChannel.appendLine(`Error: ${errorMsg}`);
-
-            void vscode.window.showErrorMessage(
-                `Failed to execute post-install script for Swift ${version}. Check the output channel for details.`
-            );
+            logger?.error(Error("Failed to execute post-install script", { cause: error }));
+            void vscode.window
+                .showErrorMessage(
+                    `Failed to execute post-install script for Swift ${version}. See command output for more details.`,
+                    "Show Command Output"
+                )
+                .then(selected => {
+                    if (!selected) {
+                        return;
+                    }
+                    outputChannel.show();
+                });
         }
     }
 

test/unit-tests/toolchain/swiftly.test.ts

@@ -1131,6 +1131,7 @@ apt-get -y install build-essential`;
 
             // @ts-expect-error mocking vscode window methods makes type checking difficult
             mockVscodeWindow.showWarningMessage.resolves("Execute Script");
+            mockVscodeWindow.showErrorMessage.resolves(undefined);
 
             await Swiftly.installToolchain("6.0.0", "/path/to/extension");