Skip to content

Remove externalComplex test completely. #9257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove externalComplex test completely. #9257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 37 additions & 33 deletions Tests/FunctionalTests/DependencyResolutionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,39 +160,43 @@ struct DependencyResolutionTests {
}
}

@Test(
.IssueWindowsLongPath,
.IssueLdFailsUnexpectedly,
.tags(
Tag.Feature.Command.Build,
),
arguments: SupportedBuildSystemOnAllPlatforms,
BuildConfiguration.allCases,
)
func externalComplex(
buildSystem: BuildSystemProvider.Kind,
configuration: BuildConfiguration,
) async throws {
try await withKnownIssue(isIntermittent: ProcessInfo.hostOperatingSystem == .windows){
try await fixture(name: "DependencyResolution/External/Complex") { fixturePath in
let packageRoot = fixturePath.appending("app")
try await executeSwiftBuild(
packageRoot,
configuration: configuration,
buildSystem: buildSystem,
)
let binPath = try packageRoot.appending(components: buildSystem.binPath(for: configuration))
let executablePath = binPath.appending(components: "Dealer")
expectFileExists(at: executablePath)
let output = try await AsyncProcess.checkNonZeroExit(args: executablePath.pathString)
.withSwiftLineEnding
#expect(output == "♣︎K\n♣︎Q\n♣︎J\n♣︎10\n♣︎9\n♣︎8\n♣︎7\n♣︎6\n♣︎5\n♣︎4\n")
}
} when: {
ProcessInfo.hostOperatingSystem == .windows // due to long path issues
|| (ProcessInfo.isHostAmazonLinux2() && buildSystem == .swiftbuild) // Linker ld throws an unexpected error.
}
}
// Remove test completely until root issues are resolved
// has caused trouble in multiple ways for weeks.
// https://github.com/swiftlang/swift-package-manager/issues/9249

// @Test(
// .IssueWindowsLongPath,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue ( blocking): instead of commenting out this test, add a .disabled() and .issue() traits to ensure, that at a minimum, the the test still compiles.

// .IssueLdFailsUnexpectedly,
// .tags(
// Tag.Feature.Command.Build,
// ),
// arguments: SupportedBuildSystemOnAllPlatforms,
// BuildConfiguration.allCases,
// )
// func externalComplex(
// buildSystem: BuildSystemProvider.Kind,
// configuration: BuildConfiguration,
// ) async throws {
// try await withKnownIssue(isIntermittent: ProcessInfo.hostOperatingSystem == .windows){
// try await fixture(name: "DependencyResolution/External/Complex") { fixturePath in
// let packageRoot = fixturePath.appending("app")
// try await executeSwiftBuild(
// packageRoot,
// configuration: configuration,
// buildSystem: buildSystem,
// )
// let binPath = try packageRoot.appending(components: buildSystem.binPath(for: configuration))
// let executablePath = binPath.appending(components: "Dealer")
// expectFileExists(at: executablePath)
// let output = try await AsyncProcess.checkNonZeroExit(args: executablePath.pathString)
// .withSwiftLineEnding
// #expect(output == "♣︎K\n♣︎Q\n♣︎J\n♣︎10\n♣︎9\n♣︎8\n♣︎7\n♣︎6\n♣︎5\n♣︎4\n")
// }
// } when: {
// ProcessInfo.hostOperatingSystem == .windows // due to long path issues
// || (ProcessInfo.isHostAmazonLinux2() && buildSystem == .swiftbuild) // Linker ld throws an unexpected error.
// }
// }

@Test(
.IssueProductTypeForObjectLibraries,
Expand Down